Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 2734673002: Send error notifications only for files in analysis roots (and not excluded). (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index 1ed2a48fca111be7c718359104a7b29debff7077..7f6e898b054328daef6bed83441396e5faf52f53 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -1864,14 +1864,18 @@ class ServerContextManagerCallbacks extends ContextManagerCallbacks {
NotificationManager notificationManager =
analysisServer.notificationManager;
String path = result.path;
- if (notificationManager != null) {
- notificationManager.recordAnalysisErrors(
- NotificationManager.serverId,
- path,
- server.doAnalysisError_listFromEngine(
- result.driver.analysisOptions, result.lineInfo, result.errors));
- } else {
- new_sendErrorNotification(analysisServer, result);
+ if (analysisServer.shouldSendErrorsNotificationFor(path)) {
+ if (notificationManager != null) {
+ notificationManager.recordAnalysisErrors(
+ NotificationManager.serverId,
+ path,
+ server.doAnalysisError_listFromEngine(
+ result.driver.analysisOptions,
+ result.lineInfo,
+ result.errors));
+ } else {
+ new_sendErrorNotification(analysisServer, result);
+ }
}
CompilationUnit unit = result.unit;
if (unit != null) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698