Make much of gfx::Range[F] constexpr.

Make much of gfx::Range[F] constexpr.

Range is a simply class that contains a pair of values, and it's useful for
tests to have constexpr objects of Range type.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2734663002
Cr-Commit-Position: refs/heads/master@{#455260}
Committed: https://chromium.googlesource.com/chromium/src/+/ad5e4c8145e3b79a8fc395f46b1371dabb62a01b

[Peter Kasting, 2017-03-05 00:30:19]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-05 00:30:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-05 00:38:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 00:38:02]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Peter Kasting, 2017-03-05 02:06:19]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-05 02:06:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-05 02:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 02:17:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peter Kasting, 2017-03-06 20:15:31]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 20:16:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-03-06 21:04:39]

pkasting@chromium.org changed reviewers:
+ rsesek@chromium.org

[Peter Kasting, 2017-03-06 21:04:39]

Note that I had to avoid std::min()/max() in the header for now as it's
constexpr in C++14 but not C++11.

[commit-bot: I haz the power, 2017-03-06 21:24:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 21:24:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Robert Sesek, 2017-03-06 21:27:58]

Does all the new inlining cause any extra bloat, or is that minimized by the
constexpr?

https://codereview.chromium.org/2734663002/diff/40001/ui/gfx/range/range_f.cc
File ui/gfx/range/range_f.cc (right):

https://codereview.chromium.org/2734663002/diff/40001/ui/gfx/range/range_f.cc...
ui/gfx/range/range_f.cc:33: size_t start = start_ > 0.0f ?
static_cast<uint32_t>(std::floor(start_)) : 0;
Should the size_t's here move to uint32_t?

[Peter Kasting, 2017-03-07 00:08:00]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[Peter Kasting, 2017-03-07 00:08:01]

On 2017/03/06 21:27:58, Robert Sesek wrote:
> Does all the new inlining cause any extra bloat, or is that minimized by the
> constexpr?

Non-scientific experiment.  I built Chromium x64 Release (not official) for
Windows locally and looked at the binary size of chrome.dll.

Trunk:   64,102,912 bytes
This CL: 64,101,888 bytes

I conclude that this makes very little difference, but is unlikely to be
strongly negative.  It wouldn't surprise me if it's a small win elsewhere as it
was above.

https://codereview.chromium.org/2734663002/diff/40001/ui/gfx/range/range_f.cc
File ui/gfx/range/range_f.cc (right):

https://codereview.chromium.org/2734663002/diff/40001/ui/gfx/range/range_f.cc...
ui/gfx/range/range_f.cc:33: size_t start = start_ > 0.0f ?
static_cast<uint32_t>(std::floor(start_)) : 0;
On 2017/03/06 21:27:58, Robert Sesek wrote:
> Should the size_t's here move to uint32_t?

Yes.  Missed those.  Thanks.

[commit-bot: I haz the power, 2017-03-07 00:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:44:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:44:59]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Robert Sesek, 2017-03-07 14:31:55]

LGTM

[Peter Kasting, 2017-03-07 21:19:21]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-03-07 21:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:39:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488921561936940,
"parent_rev": "0a3bbffbf93db594e56cf32370c78c9a4bafd128", "commit_rev":
"ad5e4c8145e3b79a8fc395f46b1371dabb62a01b"}

[commit-bot: I haz the power, 2017-03-07 22:40:29]

Description was changed from

==========
Make much of gfx::Range[F] constexpr.

Range is a simply class that contains a pair of values, and it's useful for
tests to have constexpr objects of Range type.

BUG=none
TEST=none
==========

to

==========
Make much of gfx::Range[F] constexpr.

Range is a simply class that contains a pair of values, and it's useful for
tests to have constexpr objects of Range type.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2734663002
Cr-Commit-Position: refs/heads/master@{#455260}
Committed:
https://chromium.googlesource.com/chromium/src/+/ad5e4c8145e3b79a8fc395f46b13...
==========

[commit-bot: I haz the power, 2017-03-07 22:40:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ad5e4c8145e3b79a8fc395f46b13...