DescriptionPlzNavigate: Fix the http/tests/loading/307-after-303-after-post.html and the http/tests/loading/redirect-methods.html layout tests.
These tests fail because willSendRequest() occurs before didStartProvisionalLoad(). In PlzNavigate willSendRequest is called when
we send a navigation to the browser via BeginNavigation().
Proposed fix is to remember the navigation state in decidePolicyForNavigation() and invoke BeginNavigation() when we
receive the didStartProvisionalLoad() notification.
We pass the WebURLRequest in WebFrameClient::didStartProvisionalLoad()
The other change is to remember the navigation state in a PendingNavigationInfo structure in
RenderFrameImpl. This is populated in decidePolicyForNavigation() and released in didStartProvisionalLoad().
BUG=647698, 625765
Review-Url: https://codereview.chromium.org/2734633002
Cr-Commit-Position: refs/heads/master@{#456510}
Committed: https://chromium.googlesource.com/chromium/src/+/878b2e67ac952b00b2fcafc54867f61b25507923
Patch Set 1 #
Total comments: 2
Patch Set 2 : Pass the WebURLRequest in didStartProvisionalLoad() #
Total comments: 2
Patch Set 3 : Pass WebURLRequest as a reference #Patch Set 4 : Pass WebURLRequest as a reference #Patch Set 5 : Fix compile failures #Patch Set 6 : Fix compile failures #Patch Set 7 : Fix compile failures #
Total comments: 2
Patch Set 8 : Clear pending_navigation_info_ in NavigateInternal() #
Total comments: 4
Patch Set 9 : Fix comment #Messages
Total messages: 48 (33 generated)
|