Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2734563002: Re-enable passthrough touch event queue. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
dgozman, tdresser
CC:
chromium-reviews, jam, tdresser+watch_chromium.org, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable passthrough touch event queue. Async touchmoves were going to the main thread to be ack'd by the compositor but this was useless and causing a regression in the mean input event latency. Ack async touch moves right away just like the LegacyTouchEventQueue did. BUG=697871, 642368 Review-Url: https://codereview.chromium.org/2734563002 Cr-Commit-Position: refs/heads/master@{#454977} Committed: https://chromium.googlesource.com/chromium/src/+/48123136ee6788085fc91bf856bf5e05f97da590

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -35 lines) Patch
M content/browser/renderer_host/input/input_router_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 3 chunks +8 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 10 chunks +53 lines, -20 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 5 chunks +10 lines, -3 lines 2 comments Download
M content/renderer/render_widget_unittest.cc View 3 chunks +8 lines, -1 line 0 comments Download
M ui/events/blink/web_input_event_traits.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/blink/web_input_event_traits.cc View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
dtapuska
3 years, 9 months ago (2017-03-03 22:02:13 UTC) #4
tdresser
LGTM https://codereview.chromium.org/2734563002/diff/1/content/renderer/input/input_event_filter_unittest.cc File content/renderer/input/input_event_filter_unittest.cc (right): https://codereview.chromium.org/2734563002/diff/1/content/renderer/input/input_event_filter_unittest.cc#newcode44 content/renderer/input/input_event_filter_unittest.cc:44: } Should we share the definition of this ...
3 years, 9 months ago (2017-03-06 14:24:08 UTC) #7
dtapuska
https://codereview.chromium.org/2734563002/diff/1/content/renderer/input/input_event_filter_unittest.cc File content/renderer/input/input_event_filter_unittest.cc (right): https://codereview.chromium.org/2734563002/diff/1/content/renderer/input/input_event_filter_unittest.cc#newcode44 content/renderer/input/input_event_filter_unittest.cc:44: } On 2017/03/06 14:24:08, tdresser wrote: > Should we ...
3 years, 9 months ago (2017-03-06 14:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734563002/1
3 years, 9 months ago (2017-03-06 14:44:47 UTC) #10
dtapuska
dgozman@chromium.org: Please review changes in content/renderer/render_widget_unittest.cc
3 years, 9 months ago (2017-03-06 14:47:28 UTC) #13
dgozman
lgtm
3 years, 9 months ago (2017-03-06 18:57:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734563002/1
3 years, 9 months ago (2017-03-06 21:52:04 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 22:29:15 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48123136ee6788085fc91bf856bf...

Powered by Google App Engine
This is Rietveld 408576698