Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2734493003: Pass slice info to DownloadFileImpl (Closed)

Created:
3 years, 9 months ago by qinmin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asanka, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass slice info to DownloadFileImpl When DownloadFileImpl is constructed, some slices may have already been downloaded. Pass such information to it so it can check if all file content are downloaded. BUG=644352 Review-Url: https://codereview.chromium.org/2734493003 Cr-Commit-Position: refs/heads/master@{#454985} Committed: https://chromium.googlesource.com/chromium/src/+/4373e6482a70511b1598f3f4de0170f357c06ae1

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -24 lines) Patch
M content/browser/download/download_browsertest.cc View 1 9 chunks +10 lines, -0 lines 0 comments Download
M content/browser/download/download_file_factory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/download/download_file_factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_file_impl.h View 1 4 chunks +12 lines, -6 lines 0 comments Download
M content/browser/download/download_file_impl.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 1 5 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
qinmin
PTAL
3 years, 9 months ago (2017-03-03 22:58:14 UTC) #2
xingliu
lgtm
3 years, 9 months ago (2017-03-03 23:47:27 UTC) #7
qinmin
ping, dtrainor@, would you please take a look?
3 years, 9 months ago (2017-03-06 16:21:38 UTC) #8
qinmin
+alexmos for OWNER stamp to content/public/test/test_file_error_injector.cc
3 years, 9 months ago (2017-03-06 16:23:02 UTC) #10
alexmos
content/public/test/test_file_error_injector.cc LGTM
3 years, 9 months ago (2017-03-06 17:44:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734493003/1
3 years, 9 months ago (2017-03-06 18:27:29 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/377550) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 9 months ago (2017-03-06 18:31:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734493003/20001
3 years, 9 months ago (2017-03-06 21:45:29 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 22:48:10 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4373e6482a70511b1598f3f4de01...

Powered by Google App Engine
This is Rietveld 408576698