Incognito mode behavior for 3rd party Android payment apps.

Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

In addition, the "Request cancelled" rejection string is now an
AbortError, according to the spec change here:
https://github.com/w3c/browser-payment-api/commit/361e72084830d4c9aa3b09c8c1f08dc316dc71ce

The spec change is cosmetic and does not require web developers to
change their websites.

BUG=698310
Review-Url: https://codereview.chromium.org/2734493002
Cr-Commit-Position: refs/heads/master@{#457187}
Committed: https://chromium.googlesource.com/chromium/src/+/d0deb19af7f210edc9d644cb1240f742f755d5c2

[please use gerrit instead, 2017-03-03 19:07:51]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 19:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 19:11:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 19:11:36]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[please use gerrit instead, 2017-03-03 19:16:01]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2017-03-03 19:23:28]

Patchset #1 (id:20001) has been deleted

[please use gerrit instead, 2017-03-03 19:23:38]

Patchset #1 (id:40001) has been deleted

[please use gerrit instead, 2017-03-03 19:24:02]

Description was changed from

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) canMakePayments() always returns true.
2) show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

to

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() always returns true.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY of the payment app.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

[please use gerrit instead, 2017-03-03 19:24:27]

Description was changed from

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() always returns true.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY of the payment app.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

to

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() always returns true.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

[please use gerrit instead, 2017-03-03 19:24:53]

Description was changed from

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() always returns true.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

to

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

[please use gerrit instead, 2017-03-03 19:31:54]

Patchset #1 (id:60001) has been deleted

[please use gerrit instead, 2017-03-03 19:35:22]

rouslan@chromium.org changed reviewers:
+ gogerald@chromium.org

[please use gerrit instead, 2017-03-03 19:35:23]

Ganggui, ptal.

[gogerald1, 2017-03-03 21:32:09]

lgtm with a comment,

https://codereview.chromium.org/2734493002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2734493002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:139:
if (mIsReadyToPayIntent.getPackage() == null) {
Should be getComponent here? since package name always be set in constructor,

[please use gerrit instead, 2017-03-09 19:54:59]

Description was changed from

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

BUG=698310
==========

to

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

In addition, the "Request cancelled" rejection string is now an
AbortError, according to the spec change here:
https://github.com/w3c/browser-payment-api/commit/361e72084830d4c9aa3b09c8c1f...

The spec change is cosmetic and does not require web developers to
change their websites.

BUG=698310
==========

[please use gerrit instead, 2017-03-10 14:53:10]

Will send to CQ after http://crrev.com/2645813006 lands.

https://codereview.chromium.org/2734493002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2734493002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:139:
if (mIsReadyToPayIntent.getPackage() == null) {
On 2017/03/03 21:32:09, gogerald1 wrote:
> Should be getComponent here? since package name always be set in constructor,

Done.

[please use gerrit instead, 2017-03-15 01:19:47]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-03-15 01:19:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2734493002/#ps160001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-15 01:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:23:07]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-03-15 13:48:08]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-03-15 13:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2734493002/#ps180001
(title: "Fix test")

[commit-bot: I haz the power, 2017-03-15 13:48:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:07:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:07:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-03-15 17:14:43]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-03-15 17:14:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
gogerald@chromium.org
Link to the patchset: https://codereview.chromium.org/2734493002/#ps200001
(title: "Fix test")

[commit-bot: I haz the power, 2017-03-15 17:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 18:44:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:44:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2017-03-15 19:46:23]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2017-03-15 19:46:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 20:26:24]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1489607183943510,
"parent_rev": "c11f641e886c8c1c3fa9c7133452cf8902830411", "commit_rev":
"d0deb19af7f210edc9d644cb1240f742f755d5c2"}

[commit-bot: I haz the power, 2017-03-15 20:27:13]

Description was changed from

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

In addition, the "Request cancelled" rejection string is now an
AbortError, according to the spec change here:
https://github.com/w3c/browser-payment-api/commit/361e72084830d4c9aa3b09c8c1f...

The spec change is cosmetic and does not require web developers to
change their websites.

BUG=698310
==========

to

==========
Incognito mode behavior for 3rd party Android payment apps.

Changes to incognito mode behavior of web payments API in this patch:
1) PaymentRequest.canMakePayments() never returns false.
2) PaymentRequest.show() never returns NotSupportedError.
3) Chrome does not query IS_READY_TO_PAY in payment apps.
4) Chrome shows a warning message before invoking a payment app.

In addition, the "Request cancelled" rejection string is now an
AbortError, according to the spec change here:
https://github.com/w3c/browser-payment-api/commit/361e72084830d4c9aa3b09c8c1f...

The spec change is cosmetic and does not require web developers to
change their websites.

BUG=698310

Review-Url: https://codereview.chromium.org/2734493002
Cr-Commit-Position: refs/heads/master@{#457187}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0deb19af7f210edc9d644cb1240...
==========

[commit-bot: I haz the power, 2017-03-15 20:27:14]

Committed patchset #7 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/d0deb19af7f210edc9d644cb1240...