TabRestore page load metrics does not track app background UMA properly

TabRestore page load metrics does not track app background UMA properly

When the app enters the background only *uncommitted* page loads are
tracked, but only committed page loads should be tracked.

BUG=699593
Review-Url: https://codereview.chromium.org/2734363002
Cr-Commit-Position: refs/heads/master@{#455505}
Committed: https://chromium.googlesource.com/chromium/src/+/6e510ddd1c70af1adefaf1ccc5ee42286dcd0ac3

[RyanSturm, 2017-03-08 17:41:38]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 17:41:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-03-08 17:44:14]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 17:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-03-08 17:44:44]

The CQ bit was checked by ryansturm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 17:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[RyanSturm, 2017-03-08 17:47:20]

ryansturm@chromium.org changed reviewers:
+ csharrison@chromium.org

[RyanSturm, 2017-03-08 17:47:20]

csharrison: PTAL, Thanks for spotting the info.did_commit problem in the media
CL (same issue here). I added test here and cleaned up some similar issues that
you raised in the media CL.

[Charlie Harrison, 2017-03-08 17:58:25]

Hmm, a change like this might warrant a histogram versioning. Up to you though
lgtm.

[RyanSturm, 2017-03-08 18:18:33]

On 2017/03/08 17:58:25, Charlie Harrison wrote:
> Hmm, a change like this might warrant a histogram versioning. Up to you though
> lgtm.

I don't think we need versioning for this. I'll look at how the UMA changes
version to version and keep the few consumers aware that some of the data is
missing/incorrect.

[RyanSturm, 2017-03-08 18:32:03]

The CQ bit was unchecked by ryansturm@chromium.org

[RyanSturm, 2017-03-08 18:32:03]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 18:53:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488997923369410,
"parent_rev": "3e97d4db7e7a6bd09f0dea98fb347ce61bdcda05", "commit_rev":
"6e510ddd1c70af1adefaf1ccc5ee42286dcd0ac3"}

[commit-bot: I haz the power, 2017-03-08 18:54:23]

Description was changed from

==========
TabRestore page load metrics does not track app background UMA properly

When the app enters the background only *uncommitted* page loads are
tracked, but only committed page loads should be tracked.

BUG=699593
==========

to

==========
TabRestore page load metrics does not track app background UMA properly

When the app enters the background only *uncommitted* page loads are
tracked, but only committed page loads should be tracked.

BUG=699593

Review-Url: https://codereview.chromium.org/2734363002
Cr-Commit-Position: refs/heads/master@{#455505}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e510ddd1c70af1adefaf1ccc5ee...
==========

[commit-bot: I haz the power, 2017-03-08 18:54:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6e510ddd1c70af1adefaf1ccc5ee...