RenderTextMac: Fix crash when passed an invalid font.

RenderTextMac: Fix crash when passed an invalid font.

RenderTextMac currently crashes when rendering text if it is passed a FontList
with a nil native font. This can generally happen if the Font used was created 
from a font name. 

This CL modifies RenderTextMac to ensure that if an invalid font list is passed, 
the default font list (or a font list derived from it) is used instead. Also 
added a unit test which fails on master and demonstrates the problem.

BUG=668058, 368192
Review-Url: https://codereview.chromium.org/2734333005
Cr-Commit-Position: refs/heads/master@{#455833}
Committed: https://chromium.googlesource.com/chromium/src/+/d8958dbde3315979308abe86880cba48879f010c

[karandeepb, 2017-03-08 23:27:53]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 23:28:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2017-03-09 00:41:38]

Description was changed from

==========
RenderTextMac: Fix crash when passed an invalid font.
==========

to

==========
RenderTextMac: Fix crash when passed an invalid font.

RenderTextMac currently crashes when rendering text if it is passed a FontList
with a nil native font. This can generally happen if the Font used was created 
from a font name. 

This CL modifies RenderTextMac to ensure that if an invalid font list is passed,

the default font list (or a font list derived from it) is used instead. Also 
added a unit test which fails on master and demonstrates the problem.

BUG=668058, 368192
==========

[commit-bot: I haz the power, 2017-03-09 00:57:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 00:57:11]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2017-03-09 01:31:28]

Patchset #2 (id:10001) has been deleted

[karandeepb, 2017-03-09 01:33:32]

karandeepb@chromium.org changed reviewers:
+ asvitkine@chromium.org

[karandeepb, 2017-03-09 01:33:32]

PTAL asvitkine@. For more context, please see my comments on issue 668058.

https://codereview.chromium.org/2734333005/diff/1/ui/gfx/render_text_mac.mm
File ui/gfx/render_text_mac.mm (right):

https://codereview.chromium.org/2734333005/diff/1/ui/gfx/render_text_mac.mm#n...
ui/gfx/render_text_mac.mm:115: // Ensure the font list used has a valid native
font.
We may need to do something similar in the base RenderText class itself, since
RTHB also crashes on Mac when passed an invalid font name.

[Alexei Svitkine (slow), 2017-03-09 16:08:16]

lgtm

[karandeepb, 2017-03-09 18:33:11]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2017-03-09 18:33:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 19:43:21]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1489084391626750,
"parent_rev": "1c9682f425c50e4a56bb52a848a1378973d0ef73", "commit_rev":
"d8958dbde3315979308abe86880cba48879f010c"}

[commit-bot: I haz the power, 2017-03-09 19:44:03]

Description was changed from

==========
RenderTextMac: Fix crash when passed an invalid font.

RenderTextMac currently crashes when rendering text if it is passed a FontList
with a nil native font. This can generally happen if the Font used was created 
from a font name. 

This CL modifies RenderTextMac to ensure that if an invalid font list is passed,

the default font list (or a font list derived from it) is used instead. Also 
added a unit test which fails on master and demonstrates the problem.

BUG=668058, 368192
==========

to

==========
RenderTextMac: Fix crash when passed an invalid font.

RenderTextMac currently crashes when rendering text if it is passed a FontList
with a nil native font. This can generally happen if the Font used was created 
from a font name. 

This CL modifies RenderTextMac to ensure that if an invalid font list is passed,

the default font list (or a font list derived from it) is used instead. Also 
added a unit test which fails on master and demonstrates the problem.

BUG=668058, 368192

Review-Url: https://codereview.chromium.org/2734333005
Cr-Commit-Position: refs/heads/master@{#455833}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8958dbde3315979308abe86880c...
==========

[commit-bot: I haz the power, 2017-03-09 19:44:04]

Committed patchset #2 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/d8958dbde3315979308abe86880c...