Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: ios/clean/chrome/browser/browser_coordinator.h

Issue 2734333003: Child coordinators notify their parent upon -start and -stop. (Closed)
Patch Set: Fix tests build (they were on the "all" target) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/browser_coordinator.h
diff --git a/ios/clean/chrome/browser/browser_coordinator.h b/ios/clean/chrome/browser/browser_coordinator.h
index 6b0654307f7d1262944b5c8d76179dbb32051637..6fdbdf88be3380ab93265f7cbe3093a88b56867e 100644
--- a/ios/clean/chrome/browser/browser_coordinator.h
+++ b/ios/clean/chrome/browser/browser_coordinator.h
@@ -30,15 +30,19 @@ class Browser;
@property(nonatomic, assign) Browser* browser;
// The basic lifecycle methods for coordinators are -start and -stop. These
-// are blank template methods; child classes are expected to implement them and
-// do not need to invoke the superclass methods.
+// implementations only notify the parent coordinator when this coordinator did
+// start and will stop. Child classes are expected to override and call the
+// superclass method at the end of -start and at the beginning of -stop.
+
// Starts the user interaction managed by the receiver. Typical implementations
// will create a view controller and then use |baseViewController| to present
-// it.
-- (void)start;
+// it. This method needs to be called at the end of the overriding
+// implementation.
+- (void)start NS_REQUIRES_SUPER;
-// Stops the user interaction managed by the receiver.
-- (void)stop;
+// Stops the user interaction managed by the receiver. This method needs to be
+// called at the end of the overriding implementation.
rohitrao (ping after 24h) 2017/03/08 13:01:03 Called at the beginning, not the end?
lpromero 2017/03/08 13:45:41 Done.
+- (void)stop NS_REQUIRES_SUPER;
@end

Powered by Google App Engine
This is Rietveld 408576698