Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ios/clean/chrome/browser/browser_coordinator.mm

Issue 2734333003: Child coordinators notify their parent upon -start and -stop. (Closed)
Patch Set: Fix tests build (they were on the "all" target) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/browser_coordinator.mm
diff --git a/ios/clean/chrome/browser/browser_coordinator.mm b/ios/clean/chrome/browser/browser_coordinator.mm
index 4c7af0135dd761155086e43f6fde736500bfa6e3..02b68751aa0eb4ea8512b6a15f6e15cd14e6c675 100644
--- a/ios/clean/chrome/browser/browser_coordinator.mm
+++ b/ios/clean/chrome/browser/browser_coordinator.mm
@@ -43,11 +43,11 @@
#pragma mark - Public API
- (void)start {
- // Default implementation is a no-op.
+ [self.parentCoordinator childCoordinatorDidStart:self];
}
- (void)stop {
- // Default implementation is a no-op.
+ [self.parentCoordinator childCoordinatorWillStop:self];
}
@end
@@ -122,4 +122,12 @@
coordinator.parentCoordinator = nil;
}
+- (void)childCoordinatorDidStart:(BrowserCoordinator*)coordinator {
+ // Default implementation is a no-op.
+}
+
+- (void)childCoordinatorWillStop:(BrowserCoordinator*)coordinator {
+ // Default implementation is a no-op.
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698