Re-landing of "replace TrySync with Metadata".

Re-landing of "replace TrySync with Metadata".

Use that to sync variables to predefined stack
slots inside of exception handler, not before
each MayThrow() instruction.

In JIT mode we can avoid storing extra metadata
by using deopt info instead.

Introduce caching of metadata and
exception handler based on PC.

R=fschneider@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/170aa901585cb3180cabf16dc476c0bf255fe9a7

[Dmitry Olshansky, 2017-03-08 16:38:59]

dmitryolsh@google.com changed reviewers:
+ fschneider@chromium.org, vegorov@google.com

[Dmitry Olshansky, 2017-03-08 16:38:59]

This is reworked version of the lastly reviewed CL.
I had to pull it out because of an ugly memory leak.

Notable change - this time around meta-data is ref-counted and FixedCache was
simplified to just rely on destructors being called at the right time.

[Florian Schneider, 2017-03-09 16:33:32]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2017-03-09 16:33:33]

lgtm

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h
File runtime/vm/exceptions.h (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h#new...
runtime/vm/exceptions.h:112: : data(data_), ref_count(new intptr_t(1)) {}
Style: Private fields end with _. Rename parameter to 'data' and the member to
'data_'

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h#new...
runtime/vm/exceptions.h:161: intptr_t* ref_count;
s/ref_count/ref_count_/g

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache.h
File runtime/vm/fixed_cache.h (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache.h#ne...
runtime/vm/fixed_cache.h:60: public:
Why public?

[Vyacheslav Egorov (Google), 2017-03-10 08:29:33]

lgtm

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache_test.cc
File runtime/vm/fixed_cache_test.cc (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache_test...
runtime/vm/fixed_cache_test.cc:62: ~Resource() { delete stuff; }
You need a test that destructor is actually invoked.

[Dmitry Olshansky, 2017-03-13 12:26:31]

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h
File runtime/vm/exceptions.h (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h#new...
runtime/vm/exceptions.h:112: : data(data_), ref_count(new intptr_t(1)) {}
On 2017/03/09 16:33:32, Florian Schneider wrote:
> Style: Private fields end with _. Rename parameter to 'data' and the member to
> 'data_'

Done.

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/exceptions.h#new...
runtime/vm/exceptions.h:161: intptr_t* ref_count;
On 2017/03/09 16:33:32, Florian Schneider wrote:
> s/ref_count/ref_count_/g

Done.

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache.h
File runtime/vm/fixed_cache.h (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache.h#ne...
runtime/vm/fixed_cache.h:60: public:
On 2017/03/09 16:33:33, Florian Schneider wrote:
> Why public?

Done.

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache_test.cc
File runtime/vm/fixed_cache_test.cc (right):

https://codereview.chromium.org/2734323003/diff/1/runtime/vm/fixed_cache_test...
runtime/vm/fixed_cache_test.cc:62: ~Resource() { delete stuff; }
On 2017/03/10 08:29:33, Vyacheslav Egorov (Google) wrote:
> You need a test that destructor is actually invoked.

Done.

[Dmitry Olshansky, 2017-03-13 12:27:18]

Description was changed from

==========
Re-landing of "replace TrySync with Metadata".

Use that to sync variables to predefined stack
slots inside of exception handler, not before
each MayThrow() instruction.

In JIT mode we can avoid storing extra metadata
by using deopt info instead.

Introduce caching of metadata and
exception handler based on PC.
==========

to

==========
Re-landing of "replace TrySync with Metadata".

Use that to sync variables to predefined stack
slots inside of exception handler, not before
each MayThrow() instruction.

In JIT mode we can avoid storing extra metadata
by using deopt info instead.

Introduce caching of metadata and
exception handler based on PC.

R=fschneider@google.com, vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/170aa901585cb3180cabf16dc476c0bf255fe9a7
==========

[Dmitry Olshansky, 2017-03-13 12:27:19]

Committed patchset #2 (id:20001) manually as
170aa901585cb3180cabf16dc476c0bf255fe9a7 (presubmit successful).