Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 2734323003: Re-landing of "replace TrySync with Metadata". (Closed)
Patch Set: Address review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_arm64.cc
diff --git a/runtime/vm/flow_graph_compiler_arm64.cc b/runtime/vm/flow_graph_compiler_arm64.cc
index c1d4a0c4c42239749d62dc30d6fd87ca4787ab17..d93adebc54470fd641b231203f3ec03be03981cb 100644
--- a/runtime/vm/flow_graph_compiler_arm64.cc
+++ b/runtime/vm/flow_graph_compiler_arm64.cc
@@ -1078,8 +1078,7 @@ void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
RawPcDescriptors::Kind kind,
LocationSummary* locs) {
__ BranchLink(stub_entry);
- AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, Thread::kNoDeoptId, kind, locs);
}
@@ -1088,8 +1087,7 @@ void FlowGraphCompiler::GeneratePatchableCall(TokenPosition token_pos,
RawPcDescriptors::Kind kind,
LocationSummary* locs) {
__ BranchLinkPatchable(stub_entry);
- AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, Thread::kNoDeoptId, kind, locs);
}
@@ -1099,8 +1097,7 @@ void FlowGraphCompiler::GenerateDartCall(intptr_t deopt_id,
RawPcDescriptors::Kind kind,
LocationSummary* locs) {
__ BranchLinkPatchable(stub_entry);
- AddCurrentDescriptor(kind, deopt_id, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, deopt_id, kind, locs);
// Marks either the continuation point in unoptimized code or the
// deoptimization point in optimized code, after call.
const intptr_t deopt_id_after = Thread::ToDeoptAfter(deopt_id);
@@ -1126,8 +1123,7 @@ void FlowGraphCompiler::GenerateStaticDartCall(intptr_t deopt_id,
ASSERT(is_optimizing());
__ BranchLinkWithEquivalence(stub_entry, target);
- AddCurrentDescriptor(kind, deopt_id, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, deopt_id, kind, locs);
// Marks either the continuation point in unoptimized code or the
// deoptimization point in optimized code, after call.
const intptr_t deopt_id_after = Thread::ToDeoptAfter(deopt_id);
@@ -1148,8 +1144,7 @@ void FlowGraphCompiler::GenerateRuntimeCall(TokenPosition token_pos,
intptr_t argument_count,
LocationSummary* locs) {
__ CallRuntime(entry, argument_count);
- AddCurrentDescriptor(RawPcDescriptors::kOther, deopt_id, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, deopt_id, RawPcDescriptors::kOther, locs);
if (deopt_id != Thread::kNoDeoptId) {
// Marks either the continuation point in unoptimized code or the
// deoptimization point in optimized code, after call.
@@ -1283,6 +1278,7 @@ void FlowGraphCompiler::EmitMegamorphicInstanceCall(
// arguments are removed.
AddCurrentDescriptor(RawPcDescriptors::kDeopt, deopt_id_after, token_pos);
}
+ EmitCatchEntryState(pending_deoptimization_env_, try_index);
__ Drop(argument_count);
}
@@ -1303,8 +1299,8 @@ void FlowGraphCompiler::EmitSwitchableInstanceCall(const ICData& ic_data,
__ LoadUniqueObject(R5, ic_data);
__ blr(TMP);
- AddCurrentDescriptor(RawPcDescriptors::kOther, Thread::kNoDeoptId, token_pos);
- RecordSafepoint(locs);
+ EmitCallsiteMetaData(token_pos, Thread::kNoDeoptId, RawPcDescriptors::kOther,
+ locs);
const intptr_t deopt_id_after = Thread::ToDeoptAfter(deopt_id);
if (is_optimizing()) {
AddDeoptIndexAtCall(deopt_id_after);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698