Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2734303002: fold both_gn_and_gyp and gn_only groups into gn_all (Closed)

Created:
3 years, 9 months ago by tfarina
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Wez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fold both_gn_and_gyp and gn_only groups into gn_all It is not necessary to have them anymore now that GYP build is gone. BUG=695174 R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2734303002 Cr-Commit-Position: refs/heads/master@{#455566} Committed: https://chromium.googlesource.com/chromium/src/+/fbc99249d5d02c81d0f42ffb9f6af28b1451f442

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -132 lines) Patch
M BUILD.gn View 3 chunks +115 lines, -132 lines 2 comments Download

Messages

Total messages: 13 (8 generated)
tfarina
3 years, 9 months ago (2017-03-08 01:55:17 UTC) #4
Dirk Pranke
lgtm https://codereview.chromium.org/2734303002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2734303002/diff/1/BUILD.gn#newcode584 BUILD.gn:584: if (!is_ios) { Do you feel like merging ...
3 years, 9 months ago (2017-03-08 02:13:36 UTC) #5
tfarina
https://codereview.chromium.org/2734303002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2734303002/diff/1/BUILD.gn#newcode584 BUILD.gn:584: if (!is_ios) { On 2017/03/08 02:13:36, Dirk Pranke wrote: ...
3 years, 9 months ago (2017-03-08 22:17:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734303002/1
3 years, 9 months ago (2017-03-08 22:18:23 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 22:44:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbc99249d5d02c81d0f42ffb9f6a...

Powered by Google App Engine
This is Rietveld 408576698