Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2734283002: Check that tab switcher is active/inactive before visibility check. (Closed)

Created:
3 years, 9 months ago by kkhorimoto
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Check that tab switcher is active/inactive before visibility check. As shown in the referenced bug, testCloseAllTabs was failing because the stack view visibility check was checking for a nil stack view. This is likely occurring because the visibility check was occurring before the touch event that should show the tab switcher is handled. Adding this condition will wait for the touch event to be handled before checking for visibility. BUG=693517 Review-Url: https://codereview.chromium.org/2706403006 Cr-Commit-Position: refs/heads/master@{#455293} (cherry picked from commit 389418d676c37f1c98ac289da1b57b68888bd701) Review-Url: https://codereview.chromium.org/2734283002 . Cr-Commit-Position: refs/branch-heads/3029@{#56} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/93e9aa4f35bdab24144198126026bfd57ba6af48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M ios/chrome/browser/ui/stack_view/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/stack_view/stack_view_egtest.mm View 7 chunks +30 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kkhorimoto
3 years, 9 months ago (2017-03-08 01:25:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93e9aa4f35bdab24144198126026bfd57ba6af48.

Powered by Google App Engine
This is Rietveld 408576698