Remove dashed focus rect from Views checkboxes.

ui/views/controls/button/checkbox.cc

Index: ui/views/controls/button/checkbox.cc
diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc
index 91d3a23f875ce24a3a4a82e3d76ade8634a2351a..7892b71719f08022f360d4e83426d72f8636aa25 100644
--- a/ui/views/controls/button/checkbox.cc
+++ b/ui/views/controls/button/checkbox.cc
@@ -104,18 +104,6 @@ bool Checkbox::UseMd() {
   return ui::MaterialDesignController::IsSecondaryUiMaterial();
 }
 
-void Checkbox::Layout() {
-  LabelButton::Layout();
-
-  if (!UseMd()) {
-    // Construct a focus painter that only surrounds the label area.
-    gfx::Rect rect = label()->GetMirroredBounds();
-    rect.Inset(-2, 3);
-    SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(gfx::Insets(

[tapted, 2017/03/08 00:26:43]

The LabelButton constructor still sets a FocusPainter, and I don't think things
will call SetStyle(..) on checkbox to remove it. Should the Checkbox constructor
call SetFocusPainter(nullptr) unconditionally rather than just when UseMd() is
true?

[Evan Stade, 2017/03/08 00:38:17]

yes!

-        rect.y(), rect.x(), height() - rect.bottom(), width() - rect.right())));
-  }
-}
-
 const char* Checkbox::GetClassName() const {
   return kViewClassName;
 }