Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2734253003: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.8
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry Revision: 84ff6e4c1997b63c01e95504c31ee6c5504430d5 Merged: MIPS: Fix int64->int32 lowering in wasm-to-interpeter entry on big-endian archs. Revision: 4f426e104dd67d2dd72bf44aef70c032eea3be7d NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=titzer@chromium.org BUG=v8:6043 Review-Url: https://codereview.chromium.org/2734253003 . Cr-Commit-Position: refs/branch-heads/5.8@{#17} Cr-Branched-From: eda659cc5e307f20ac1ad542ba12ab32eaf4c7ef-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd02d2160b1457baed81a2f40063eb264a21-refs/heads/master@{#43429} Committed: https://chromium.googlesource.com/v8/v8/+/8dd111761dd38fb4d8449c1ecc3dc6de12839b20

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M src/compiler/wasm-compiler.cc View 3 chunks +26 lines, -14 lines 0 comments Download
M src/utils.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/wasm/wasm-debug.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Clemens Hammacher
3 years, 9 months ago (2017-03-08 15:43:01 UTC) #1
titzer
On 2017/03/08 15:43:01, Clemens Hammacher wrote: lgtm (rubber-stamped)
3 years, 9 months ago (2017-03-08 15:52:00 UTC) #2
Clemens Hammacher
3 years, 9 months ago (2017-03-08 15:53:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dd111761dd38fb4d8449c1ecc3dc6de12839b20 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698