Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2734173003: [WASM] Fix failing F32x4 Equal, NotEqual tests. (Closed)

Created:
3 years, 9 months ago by bbudge
Modified:
3 years, 9 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[WASM] Fix failing F32x4 Equal, NotEqual tests. - Fix typo, compare operand diff should be a float. LOG=N BUG=v8:6020 Review-Url: https://codereview.chromium.org/2734173003 Cr-Commit-Position: refs/heads/master@{#43651} Committed: https://chromium.googlesource.com/v8/v8/+/b23f6a462e02662f1c6c13b890b5b62967410a4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/wasm/test-run-wasm-simd.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bbudge
3 years, 9 months ago (2017-03-07 17:12:27 UTC) #4
bbudge
3 years, 9 months ago (2017-03-07 17:20:46 UTC) #5
Mircea Trofin
lgtm
3 years, 9 months ago (2017-03-07 17:30:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734173003/1
3 years, 9 months ago (2017-03-07 17:50:33 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:52:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b23f6a462e02662f1c6c13b890b5b629674...

Powered by Google App Engine
This is Rietveld 408576698