Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2734133002: Make the OutdatedBuildDetector feature static. (Closed)

Created:
3 years, 9 months ago by grt (UTC plus 2)
Modified:
3 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the OutdatedBuildDetector feature static. BUG=none R=thakis@chromium.org Review-Url: https://codereview.chromium.org/2734133002 Cr-Commit-Position: refs/heads/master@{#455102} Committed: https://chromium.googlesource.com/chromium/src/+/986f0c79351e7216e3f9c5185fb5221049ef1ba7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
grt (UTC plus 2)
3 years, 9 months ago (2017-03-07 10:49:37 UTC) #1
Nico
lgtm
3 years, 9 months ago (2017-03-07 15:15:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734133002/1
3 years, 9 months ago (2017-03-07 15:22:02 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 17:07:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/986f0c79351e7216e3f9c5185fb5...

Powered by Google App Engine
This is Rietveld 408576698