"Bootstrap" a toolkit-views Typography spec.

ui/views/controls/label.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_LABEL_H_
 #define UI_VIEWS_CONTROLS_LABEL_H_
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/gfx/render_text.h"
 #include "ui/views/context_menu_controller.h"
 #include "ui/views/selection_controller_delegate.h"
+#include "ui/views/style/typography.h"
 #include "ui/views/view.h"
 #include "ui/views/word_lookup_client.h"
 
 namespace views {
 class LabelSelectionTest;
 class MenuRunner;
 class SelectionController;
 
 // A view subclass that can display a string.
 class VIEWS_EXPORT Label : public View,
                            public ContextMenuController,
                            public WordLookupClient,
                            public SelectionControllerDelegate,
                            public ui::SimpleMenuModel::Delegate {
  public:
   // Internal class name.
   static const char kViewClassName[];
 
   // The padding for the focus border when rendering focused text.
   static const int kFocusBorderPadding;
 
+  // Helper to construct a Label that doesn't use the views::Typography spec.
+  // Using this causes Label to obtain colors from ui::NativeTheme and line
+  // spacing from gfx::FontList::GetHeight().
+  // TOOD(tapted): Audit users of this class when MD is default. Then add

[Peter Kasting, 2017/03/17 02:26:00]

Nit: TOOD?  :)

[tapted, 2017/03/17 10:33:10]

whoops. fixed. (I have spell checking for comments, but it ignores all caps and
CamelCase - doh)

+  // foreground/background colors, line spacing and everything else that
+  // views::TextContext abstracts away so the separate setters can be removed.
+  struct CustomFont {

[Peter Kasting, 2017/03/17 02:26:00]

Nit: Just for the sake of keeping the diff minimal I might have given this a
non-explicit one-arg constructor (I know it's banned by the style guide, but I'm
OK with it as a transitionary step) to avoid the need for {} in various places
until the TODOs here are addressed.

But now that you've already done the work, I guess might as well not bother.

[tapted, 2017/03/17 10:33:10]

Yeah, I also want any new code to be considering a TextContext off the bat when
they can, rather than have a FontList slip through unnoticed..

+    // TODO(tapted): Change this to a size delta and font weight since that's
+    // typically all the callers really care about, and would allow Label to
+    // guarantee caching of the FontList in ResourceBundle.
+    const gfx::FontList& font_list;
+  };
+
+  // Create Labels with typography::CONTEXT_CONTROL_LABEL and
+  // typography::STYLE_PRIMARY.
+  // TODO(tapted): Remove these. Callers must specify a context or use the
+  // constructor taking a CustomFont.
   Label();
   explicit Label(const base::string16& text);
-  Label(const base::string16& text, const gfx::FontList& font_list);
+
+  // Construct a Label in the given |text_context|. The text_style can change

[Peter Kasting, 2017/03/17 02:26:00]

Nit: Use || consistently

[tapted, 2017/03/17 10:33:10]

Done.

+  // later, so provide a default. The |text_context| is fixed.
+  Label(const base::string16& text,
+        int text_context,
+        int text_style = typography::STYLE_PRIMARY);
+
+  // Construct a Label with the given |font| description.
+  Label(const base::string16& text, const CustomFont& font);
+
   ~Label() override;
 
   static const gfx::FontList& GetDefaultFontList();
 
   // Gets or sets the fonts used by this label.
   const gfx::FontList& font_list() const { return render_text_->font_list(); }
 
+  // TODO(tapted): Replace this with a private method, e.g., OnFontChanged().
   virtual void SetFontList(const gfx::FontList& font_list);
 
   // Get or set the label text.
   const base::string16& text() const { return render_text_->text(); }
   virtual void SetText(const base::string16& text);
 
   // Enables or disables auto-color-readability (enabled by default).  If this
   // is enabled, then calls to set any foreground or background color will
   // trigger an automatic mapper that uses color_utils::GetReadableColor() to
   // ensure that the foreground colors are readable over the background color.
@@ skipping 294 matching lines @@
   // Context menu related members.
   ui::SimpleMenuModel context_menu_contents_;
   std::unique_ptr<views::MenuRunner> context_menu_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(Label);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_LABEL_H_