chrome: remove omnibox_ev_bubble_xxx.png assets

chrome: remove omnibox_ev_bubble_xxx.png and omnibox_selected_keyword_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG=686270
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2734063002
Cr-Commit-Position: refs/heads/master@{#455605}
Committed: https://chromium.googlesource.com/chromium/src/+/9d0fedea76764c9132e6d19ec8679880339a8eef

[tfarina, 2017-03-07 01:29:17]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 01:30:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:50:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:50:59]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tfarina, 2017-03-07 01:53:19]

Aborting this.

Mac is using these assets:

../../chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:305:10:
error: use of undeclared identifier 'IDR_OMNIBOX_EV_BUBBLE_TOP_LEFT'
  return IMAGE_GRID(IDR_OMNIBOX_EV_BUBBLE);
         ^
../../ui/base/cocoa/appkit_utils.h:27:25: note: expanded from macro 'IMAGE_GRID'
#define IMAGE_GRID(x) { x ## _TOP_LEFT,    x ## _TOP,    x ## _TOP_RIGHT, \
                        ^

[Peter Kasting, 2017-03-07 02:04:25]

On 2017/03/07 01:53:19, tfarina wrote:
> Aborting this.
> 
> Mac is using these assets:
> 
>
../../chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:305:10:
> error: use of undeclared identifier 'IDR_OMNIBOX_EV_BUBBLE_TOP_LEFT'
>   return IMAGE_GRID(IDR_OMNIBOX_EV_BUBBLE);
>          ^
> ../../ui/base/cocoa/appkit_utils.h:27:25: note: expanded from macro
'IMAGE_GRID'
> #define IMAGE_GRID(x) { x ## _TOP_LEFT,    x ## _TOP,    x ## _TOP_RIGHT, \
>                         ^

Don't abort, just expand the CL to remove GetBubbleImageIds(), which looks from
code search like it's defined but never called.

[tfarina, 2017-03-07 02:59:13]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 02:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2017-03-07 03:00:23]

Ah, I see! Thanks Peter.

Please, take another look.

[tfarina, 2017-03-07 03:00:58]

Description was changed from

==========
chrome: remove omnibox_ev_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG=686270
R=pkasting@chromium.org,sky@chromium.org
==========

to

==========
chrome: remove omnibox_ev_bubble_xxx.png and
omnibox_selected_keyword_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG=686270
R=pkasting@chromium.org,sky@chromium.org
==========

[Peter Kasting, 2017-03-07 03:11:07]

LGTM

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/bubble_decoration.h (right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/bubble_decoration.h:14: #import
"ui/base/cocoa/appkit_utils.h"
Nit: This #import shouldn't be in this header, even if we still need it in some
.cc files (but hopefully removing the IMAGE_GRIDs means we don't need it at
all).

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
(right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:16:
#include "chrome/grit/theme_resources.h"
Nit: Can this be removed now?

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm
(right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm:11: #include
"chrome/grit/theme_resources.h"
Nit: Can this be removed now?

[tfarina, 2017-03-07 03:16:23]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 03:17:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2017-03-07 03:17:59]

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/bubble_decoration.h (right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/bubble_decoration.h:14: #import
"ui/base/cocoa/appkit_utils.h"
On 2017/03/07 03:11:07, Peter Kasting wrote:
> Nit: This #import shouldn't be in this header, even if we still need it in
some
> .cc files (but hopefully removing the IMAGE_GRIDs means we don't need it at
> all).

Done.

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
(right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm:16:
#include "chrome/grit/theme_resources.h"
On 2017/03/07 03:11:07, Peter Kasting wrote:
> Nit: Can this be removed now?

Done.

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm
(right):

https://codereview.chromium.org/2734063002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.mm:11: #include
"chrome/grit/theme_resources.h"
On 2017/03/07 03:11:07, Peter Kasting wrote:
> Nit: Can this be removed now?

Done.

[commit-bot: I haz the power, 2017-03-07 05:53:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:53:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tfarina, 2017-03-08 22:15:59]

Scott, ping?

[sky, 2017-03-08 22:26:10]

LGTM - sorry for missing this.

[tfarina, 2017-03-08 22:29:38]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2017-03-08 22:29:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2734063002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2017-03-08 22:29:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 23:27:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489012178418040,
"parent_rev": "6280ec5b6e3b4c307926eb1bf0167acc2a0d4a74", "commit_rev":
"a2d034c416d5623f6e5d41b6b2766a07697b11ce"}

[commit-bot: I haz the power, 2017-03-08 23:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:41:31]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[tfarina, 2017-03-09 00:06:36]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2017-03-09 00:07:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 00:15:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489017996835940,
"parent_rev": "3d4ced0b8d7081318da910aff495ed4f5f38f63e", "commit_rev":
"9d0fedea76764c9132e6d19ec8679880339a8eef"}

[commit-bot: I haz the power, 2017-03-09 00:16:21]

Description was changed from

==========
chrome: remove omnibox_ev_bubble_xxx.png and
omnibox_selected_keyword_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG=686270
R=pkasting@chromium.org,sky@chromium.org
==========

to

==========
chrome: remove omnibox_ev_bubble_xxx.png and
omnibox_selected_keyword_bubble_xxx.png assets

Remove these unused assets along with their associated IDRs.

BUG=686270
R=pkasting@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2734063002
Cr-Commit-Position: refs/heads/master@{#455605}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d0fedea76764c9132e6d19ec867...
==========

[commit-bot: I haz the power, 2017-03-09 00:16:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9d0fedea76764c9132e6d19ec867...