Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2734043004: Move textDirectionForSelection in EditingStyleUtilities class to EditorCommand.cpp (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move textDirectionForSelection in EditingStyleUtilities class to EditorCommand.cpp This patch moves |textDirectionForSelection()| to |EditingStyleUtilities| class to "EditorCommand.cpp" since it is used only in "EditorCommand.cpp" for improving code health. BUG=657237 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2734043004 Cr-Commit-Position: refs/heads/master@{#455712} Committed: https://chromium.googlesource.com/chromium/src/+/2dd2875dc248df6276c5a4aa61731e064fb14f84

Patch Set 1 : 2017-03-07T17:41:31 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -119 lines) Patch
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyleUtilities.cpp View 1 chunk +0 lines, -111 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +118 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-09 06:31:43 UTC) #7
yoichio
lgtm
3 years, 9 months ago (2017-03-09 08:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734043004/1
3 years, 9 months ago (2017-03-09 09:03:40 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 11:18:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2dd2875dc248df6276c5a4aa6173...

Powered by Google App Engine
This is Rietveld 408576698