DevTools: fix stretch layout in search/replace bar

DevTools: fix stretch layout in search/replace bar

SearchableView used to build the find and replace UI using <table>. A table
inside a flex container produced the strange behavior in the bug.

This CL fixes the visual bug, removes the table elements, and changes the layout
of the find/replace text inputs to stretch as much as possible.

BUG=698830
Review-Url: https://codereview.chromium.org/2734043002
Cr-Commit-Position: refs/heads/master@{#455244}
Committed: https://chromium.googlesource.com/chromium/src/+/336d5878c4c612627f0a8333f71b50a04b7091d1

[luoe, 2017-03-07 00:51:20]

Description was changed from

==========
DevTools: fix stretch layout in search/replace bar

BUG=698830
==========

to

==========
DevTools: fix stretch layout in search/replace bar

SearchableView used to build the find and replace UI using <table>. A table
inside a flex container produced the strange behavior in the bug.

This CL fixes the visual bug, removes the table elements, and changes the layout
of the find/replace text inputs to stretch as much as possible.

BUG=698830
==========

[luoe, 2017-03-07 00:51:55]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-03-07 00:51:55]

Please take a look

[lushnikov, 2017-03-07 02:26:01]

lgtm

https://codereview.chromium.org/2734043002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (right):

https://codereview.chromium.org/2734043002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:103:
this._nonInputElements = this._footerElement.createChild('div',
'toolbar-search-buttons hidden');
this._buttonsContainer

[luoe, 2017-03-07 02:28:55]

https://codereview.chromium.org/2734043002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (right):

https://codereview.chromium.org/2734043002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:103:
this._nonInputElements = this._footerElement.createChild('div',
'toolbar-search-buttons hidden');
On 2017/03/07 02:26:01, lushnikov wrote:
> this._buttonsContainer

That's clearer, done!

[luoe, 2017-03-07 02:28:59]

The CQ bit was checked by luoe@chromium.org

[luoe, 2017-03-07 02:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2734043002/#ps20001
(title: "ac")

[commit-bot: I haz the power, 2017-03-07 02:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 05:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:48:06]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[luoe, 2017-03-07 05:55:28]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:56:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 07:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:20:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2017-03-07 19:52:04]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 22:13:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488916324930150,
"parent_rev": "13d368e40bd49f076abb109ea3c875215098f744", "commit_rev":
"336d5878c4c612627f0a8333f71b50a04b7091d1"}

[commit-bot: I haz the power, 2017-03-07 22:14:35]

Description was changed from

==========
DevTools: fix stretch layout in search/replace bar

SearchableView used to build the find and replace UI using <table>. A table
inside a flex container produced the strange behavior in the bug.

This CL fixes the visual bug, removes the table elements, and changes the layout
of the find/replace text inputs to stretch as much as possible.

BUG=698830
==========

to

==========
DevTools: fix stretch layout in search/replace bar

SearchableView used to build the find and replace UI using <table>. A table
inside a flex container produced the strange behavior in the bug.

This CL fixes the visual bug, removes the table elements, and changes the layout
of the find/replace text inputs to stretch as much as possible.

BUG=698830

Review-Url: https://codereview.chromium.org/2734043002
Cr-Commit-Position: refs/heads/master@{#455244}
Committed:
https://chromium.googlesource.com/chromium/src/+/336d5878c4c612627f0a8333f71b...
==========

[commit-bot: I haz the power, 2017-03-07 22:14:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/336d5878c4c612627f0a8333f71b...