Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 2734033004: Compile Gallery in gyp v2. (Closed)

Created:
3 years, 9 months ago by oka
Modified:
3 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile Gallery in gyp v2. BUG=636289 TEST=run_compiler. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2734033004 Cr-Commit-Position: refs/heads/master@{#455667} Committed: https://chromium.googlesource.com/chromium/src/+/b6ea87ae5519b2da334db4a6edfd4baa46f990a2

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -232 lines) Patch
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources2.gyp View 1 chunk +15 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 3 chunks +30 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js View 1 chunk +0 lines, -17 lines 0 comments Download
D ui/file_manager/gallery/js/compiled_resources.gyp View 1 chunk +0 lines, -182 lines 0 comments Download
M ui/file_manager/gallery/js/compiled_resources2.gyp View 1 3 chunks +25 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
oka
PTAL.
3 years, 9 months ago (2017-03-08 12:41:35 UTC) #6
oka
.
3 years, 9 months ago (2017-03-08 12:43:27 UTC) #7
fukino
LGTM!
3 years, 9 months ago (2017-03-08 13:04:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734033004/20001
3 years, 9 months ago (2017-03-09 04:31:04 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 04:35:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b6ea87ae5519b2da334db4a6edfd...

Powered by Google App Engine
This is Rietveld 408576698