[Devtools] Update closure compiler

[Devtools] Update closure compiler

This patch simply updates our bundled version of closure compiler.

R=pfeldman@chromium.org, pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2734033003 .
Cr-Commit-Position: refs/heads/master@{#455330}
Committed: https://chromium.googlesource.com/chromium/src/+/04c65e9b0c773d0b3888634dd4cc9f01181a6820

[allada, 2017-03-07 23:55:22]

PTL

[allada, 2017-03-08 00:13:02]

https://codereview.chromium.org/2734033003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js (left):

https://codereview.chromium.org/2734033003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/data_grid/DataGrid.js:1221: * @this
{NODE_TYPE}
This were removed because closure started complaining about them in this update.

https://codereview.chromium.org/2734033003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/externs.js (left):

https://codereview.chromium.org/2734033003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/externs.js:364: function Path2D() {
This is now bundled in closure.

[pfeldman, 2017-03-08 00:17:24]

why did runner/validator change?

[allada, 2017-03-08 00:29:14]

On 2017/03/08 00:17:24, pfeldman wrote:
> why did runner/validator change?

It has a dependency on closure compiler. According to:
https://github.com/ChromeDevTools/devtools-frontend/tree/master/scripts#closure
you are supposed to update both when closure is updated.

[pfeldman, 2017-03-08 00:36:46]

lgtm. Okay. Do you have an idea on how stable compiler you are rolling is? It is
not official release as I gather.

[allada, 2017-03-08 00:58:07]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:58:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:05:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:05:22]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[allada, 2017-03-08 01:33:22]

On 2017/03/08 00:36:46, pfeldman wrote:
> lgtm. Okay. Do you have an idea on how stable compiler you are rolling is? It
is
> not official release as I gather.

I ran it on all of google3 with no errors. I spoke with one of the members of
the closure team and they said they often roll out once per month, but once per
week internally. He also said that externs changes (which is what I did) are
rolled out immediately across google3 though.

[allada, 2017-03-08 01:42:43]

Description was changed from

==========
[Devtools] Update closure compiler

This patch simply updates our bundled version of closure compiler.

R=pfeldman
BUG=None
==========

to

==========
[Devtools] Update closure compiler

This patch simply updates our bundled version of closure compiler.

R=pfeldman@chromium.org, pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2734033003 .
Cr-Commit-Position: refs/heads/master@{#455330}
Committed:
https://chromium.googlesource.com/chromium/src/+/04c65e9b0c773d0b3888634dd4cc...
==========

[allada, 2017-03-08 01:42:45]

Committed patchset #1 (id:1) manually as
04c65e9b0c773d0b3888634dd4cc9f01181a6820 (presubmit successful).