Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2733963003: Copy LoginReputationClientRequest/Response protos (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
Reviewers:
Nathan Parker
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy LoginReputationClientRequest/Response protos Copy LoginReputationClientRequest and LoginReputationClientResponse protos from google3 to chrome/common/safe_browsing/csd.proto BUG=698899 Review-Url: https://codereview.chromium.org/2733963003 Cr-Commit-Position: refs/heads/master@{#455215} Committed: https://chromium.googlesource.com/chromium/src/+/0fd4e054da246f044d62d18b626ff4afa68b7b72

Patch Set 1 #

Total comments: 4

Patch Set 2 : refine comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -0 lines) Patch
M chrome/common/safe_browsing/csd.proto View 1 1 chunk +100 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Jialiu Lin
Simply copy protos from google3 to chromium code base. No other change. PTAL. Thanks!
3 years, 9 months ago (2017-03-07 00:24:19 UTC) #4
Nathan Parker
lgtm https://codereview.chromium.org/2733963003/diff/1/chrome/common/safe_browsing/csd.proto File chrome/common/safe_browsing/csd.proto (right): https://codereview.chromium.org/2733963003/diff/1/chrome/common/safe_browsing/csd.proto#newcode157 chrome/common/safe_browsing/csd.proto:157: // The client may strip CGI parameters. s/may/will ...
3 years, 9 months ago (2017-03-07 00:51:02 UTC) #5
Jialiu Lin
Thanks! https://codereview.chromium.org/2733963003/diff/1/chrome/common/safe_browsing/csd.proto File chrome/common/safe_browsing/csd.proto (right): https://codereview.chromium.org/2733963003/diff/1/chrome/common/safe_browsing/csd.proto#newcode157 chrome/common/safe_browsing/csd.proto:157: // The client may strip CGI parameters. On ...
3 years, 9 months ago (2017-03-07 00:53:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733963003/20001
3 years, 9 months ago (2017-03-07 00:55:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378919)
3 years, 9 months ago (2017-03-07 03:37:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733963003/20001
3 years, 9 months ago (2017-03-07 18:26:10 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 21:00:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0fd4e054da246f044d62d18b626f...

Powered by Google App Engine
This is Rietveld 408576698