Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 2733963002: MD Settings: Debounce navigation event in side nav. (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 975292759f4e20bb16969d6f8eeaca3919964ad8..614fe55d8ae32584238419cf057fce803c9509fb 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -61,14 +61,18 @@ cr.define('settings_menu', function() {
// Test that navigating via the paper menu always clears the current
// search URL parameter.
- test('clearsUrlSearchParam', function() {
+ test('clearsUrlSearchParam', function(done) {
var urlParams = new URLSearchParams('search=foo');
settings.navigateTo(settings.Route.BASIC, urlParams);
assertEquals(
urlParams.toString(),
settings.getQueryParameters().toString());
MockInteractions.tap(settingsMenu.$.people);
- assertEquals('', settings.getQueryParameters().toString());
+
+ window.setTimeout(function() {
+ assertEquals('', settings.getQueryParameters().toString());
+ done();
+ }, 0);
dschuyler 2017/03/15 01:13:02 nit: zero is the default msec value (so it's not n
hcarmona 2017/03/15 19:22:09 Done.
});
});

Powered by Google App Engine
This is Rietveld 408576698