Chromium Code Reviews| Index: chrome/browser/resources/settings/settings_menu/settings_menu.js |
| diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| index 122f10a9f681dec320072f202d7c6b19358c557e..283a414d120a9bd11196b27a4f9b2fdaf4b16456 100644 |
| --- a/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| +++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js |
| @@ -74,11 +74,13 @@ Polymer({ |
| onSelectorActivate_: function(event) { |
|
dschuyler
2017/03/15 01:13:02
I think we can remove the inner (nested) onSelecto
hcarmona
2017/03/15 19:22:09
This unfortunately doesn't work because the items
hcarmona
2017/03/16 00:58:19
We spoke in person and I had misunderstood what yo
|
| this.setSelectedUrl_(event.detail.selected); |
| - var path = new URL(event.detail.selected).pathname; |
| - var route = settings.getRouteForPath(path); |
| - assert(route, 'settings-menu has an entry with an invalid route.'); |
| - settings.navigateTo( |
| - route, /* dynamicParams */ null, /* removeSearch */ true); |
| + this.debounce('side-nav-route-change', function() { |
| + var path = new URL(event.detail.selected).pathname; |
| + var route = settings.getRouteForPath(path); |
| + assert(route, 'settings-menu has an entry with an invalid route.'); |
| + settings.navigateTo( |
| + route, /* dynamicParams */ null, /* removeSearch */ true); |
| + }); |
| }, |
| /** |