|
|
Created:
3 years, 9 months ago by Zhenyao Mo Modified:
3 years, 9 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLimit reset_base_mipmap_level_before_texstorage driver bug workaround.
To OSX older than 10.12.4.
BUG=640506
TEST=
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2733953007
Cr-Commit-Position: refs/heads/master@{#455634}
Committed: https://chromium.googlesource.com/chromium/src/+/62643d9574be80279c2d94868216a8cf9706c11c
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= TBR=kbr@chromium.org ========== to ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc: While running git apply --index -p1; error: patch failed: gpu/config/gpu_driver_bug_list_json.cc:19 error: gpu/config/gpu_driver_bug_list_json.cc: patch does not apply Patch: gpu/config/gpu_driver_bug_list_json.cc Index: gpu/config/gpu_driver_bug_list_json.cc diff --git a/gpu/config/gpu_driver_bug_list_json.cc b/gpu/config/gpu_driver_bug_list_json.cc index 850b3eb896905f76cd4fee1819d64fa0c489b05b..afe65de0c24604482b1f75d80ceb1f91bc6aab9c 100644 --- a/gpu/config/gpu_driver_bug_list_json.cc +++ b/gpu/config/gpu_driver_bug_list_json.cc @@ -19,7 +19,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST( { "name": "gpu driver bug list", // Please update the version number whenever you change this file. - "version": "9.32", + "version": "9.33", "entries": [ { "id": 1, @@ -1899,7 +1899,11 @@ LONG_STRING_CONST( "description": "glTexStorage* are buggy when base mipmap level is not 0", "cr_bugs": [640506], "os": { - "type": "macosx" + "type": "macosx", + "version": { + "op": "<", + "value": "10.12.4" + } }, "features": [ "reset_base_mipmap_level_before_texstorage"
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM There must surely already be a bug filed about the unrelated linux_chromium_chromeos_ozone_rel_ng failures, so please comment on it and point to this CL as one of surely many affected. Thanks.
On 2017/03/09 00:49:38, Ken Russell OOO-till-Mar-13 wrote: > LGTM > > There must surely already be a bug filed about the unrelated > linux_chromium_chromeos_ozone_rel_ng failures, so please comment on it and point > to this CL as one of surely many affected. Thanks. Not really. I filed crbug.com/699832. Can you help finding an owner?
Description was changed from ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489024047166340, "parent_rev": "1372de15eab0d9365f7b3b0d006eb1a52d47edf6", "commit_rev": "62643d9574be80279c2d94868216a8cf9706c11c"}
Message was sent while issue was closed.
Description was changed from ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Limit reset_base_mipmap_level_before_texstorage driver bug workaround. To OSX older than 10.12.4. BUG=640506 TEST= NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2733953007 Cr-Commit-Position: refs/heads/master@{#455634} Committed: https://chromium.googlesource.com/chromium/src/+/62643d9574be80279c2d94868216... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/62643d9574be80279c2d94868216... |