Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2733953004: PPC/s390: [Atomics] Make Atomics.exchange a builtin using TF (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [Atomics] Make Atomics.exchange a builtin using TF Port 301c12376e5c675c5a3d5265d1bf2b3ab1e13679 R=binji@chromium.org, aseemgarg@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:4614 LOG=N Review-Url: https://codereview.chromium.org/2733953004 Cr-Commit-Position: refs/heads/master@{#43680} Committed: https://chromium.googlesource.com/v8/v8/+/c7ce19dcab241545645cea9b21c2aadf40e50a20

Patch Set 1 #

Patch Set 2 : minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M src/builtins/builtins-sharedarraybuffer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-07 22:33:18 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-07 23:01:19 UTC) #2
JoranSiu
lgtm
3 years, 9 months ago (2017-03-08 00:53:31 UTC) #3
aseemgarg
lgtm
3 years, 9 months ago (2017-03-08 01:07:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733953004/20001
3 years, 9 months ago (2017-03-08 04:11:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/33969)
3 years, 9 months ago (2017-03-08 04:13:38 UTC) #8
JaideepBajwa
+Jarin +adamk
3 years, 9 months ago (2017-03-08 17:00:27 UTC) #11
adamk
lgtm
3 years, 9 months ago (2017-03-08 18:21:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733953004/20001
3 years, 9 months ago (2017-03-08 18:31:14 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:37:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c7ce19dcab241545645cea9b21c2aadf40e...

Powered by Google App Engine
This is Rietveld 408576698