Move CompositeEditCommand::deleteSelection() to TypingCommand::deleteSelectionIfRange()

Move CompositeEditCommand::deleteSelection() to TypingCommand::deleteSelectionIfRange()

This patch moves |CompositeEditCommand::deleteSelection()| to
|TypingCommand::deleteSelectionIfRange()| since it is used only in
|TypingCommand| and reduce overload of |deleteSelection()| to improve
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2733933003
Cr-Commit-Position: refs/heads/master@{#455094}
Committed: https://chromium.googlesource.com/chromium/src/+/9cee878cc63613dcd82f06850e5ab368b0bf8e57

[yosin_UTC9, 2017-03-07 04:14:02]

Description was changed from

==========
2017-03-07T13:11:49

2017-03-07T13:11:18

BUG=
==========

to

==========
Rename CompositeEditCommand::deleteSelection() to deleteSelectionIfRange()


BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-07 04:14:08]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 04:14:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-07 04:19:54]

Description was changed from

==========
Rename CompositeEditCommand::deleteSelection() to deleteSelectionIfRange()


BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Rename CompositeEditCommand::deleteSelection() to deleteSelectionIfRange()

This patch renames |CompositeEditCommand::deleteSelection()| to
|deleteSelectionIfRange()| to reduce number of overload functions for improving
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-07 05:09:50]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-07 05:09:51]

PTAL

[yoichio, 2017-03-07 05:16:31]

https://codereview.chromium.org/2733933003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
(right):

https://codereview.chromium.org/2733933003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h:109: //
class since it is used in |TypingCommand| only.
Could you move now instead of renaming?

[yosin_UTC9, 2017-03-07 05:26:06]

Description was changed from

==========
Rename CompositeEditCommand::deleteSelection() to deleteSelectionIfRange()

This patch renames |CompositeEditCommand::deleteSelection()| to
|deleteSelectionIfRange()| to reduce number of overload functions for improving
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes
==========

to

==========
Move CompositeEditCommand::deleteSelection() to
TypingCommand::deleteSelectionIfRange()

This patch moves |CompositeEditCommand::deleteSelection()| to
|TypingCommand::deleteSelectionIfRange()| since it is used only in
|TypingCommand| and reduce overload of |deleteSelection()| to improve
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-07 05:29:46]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 05:29:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-07 05:30:14]

PTAL

Moving rather than renaming.

[commit-bot: I haz the power, 2017-03-07 07:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:15:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yoichio, 2017-03-07 07:57:29]

lgtm

[yosin_UTC9, 2017-03-07 07:59:18]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:59:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:54:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:54:30]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2017-03-07 14:37:09]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 16:38:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488897429097930,
"parent_rev": "d7489441b0cf75f530d4cc05514f146abaa07d9a", "commit_rev":
"9cee878cc63613dcd82f06850e5ab368b0bf8e57"}

[commit-bot: I haz the power, 2017-03-07 16:39:07]

Description was changed from

==========
Move CompositeEditCommand::deleteSelection() to
TypingCommand::deleteSelectionIfRange()

This patch moves |CompositeEditCommand::deleteSelection()| to
|TypingCommand::deleteSelectionIfRange()| since it is used only in
|TypingCommand| and reduce overload of |deleteSelection()| to improve
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes
==========

to

==========
Move CompositeEditCommand::deleteSelection() to
TypingCommand::deleteSelectionIfRange()

This patch moves |CompositeEditCommand::deleteSelection()| to
|TypingCommand::deleteSelectionIfRange()| since it is used only in
|TypingCommand| and reduce overload of |deleteSelection()| to improve
readability.

This patch is a preparation of replacing |VisibleSelection| parameter from
|deleteSelectionIfRange()|.

BUG=657256
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2733933003
Cr-Commit-Position: refs/heads/master@{#455094}
Committed:
https://chromium.googlesource.com/chromium/src/+/9cee878cc63613dcd82f06850e5a...
==========

[commit-bot: I haz the power, 2017-03-07 16:39:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9cee878cc63613dcd82f06850e5a...