Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2733923002: [mergeinfo.py] Use remotes/origin/master instead of master (Closed)

Created:
3 years, 9 months ago by Clemens Hammacher
Modified:
3 years, 9 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mergeinfo.py] Use remotes/origin/master instead of master I don't have a local master branch, so those commands failed for me. R=hablich@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2733923002 Cr-Commit-Position: refs/heads/master@{#43752} Committed: https://chromium.googlesource.com/v8/v8/+/9d3b8fce50058b9d5d30e14bf22a0cf8bae5a149

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M tools/release/mergeinfo.py View 2 chunks +4 lines, -5 lines 0 comments Download
M tools/release/test_mergeinfo.py View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Clemens Hammacher
3 years, 9 months ago (2017-03-06 18:57:40 UTC) #1
Michael Hablich
please run "tools/release/test_mergeinfo.py". Seems like the tests need updating too.
3 years, 9 months ago (2017-03-08 14:31:00 UTC) #2
Clemens Hammacher
On 2017/03/08 at 14:31:00, hablich wrote: > please run "tools/release/test_mergeinfo.py". Seems like the tests need ...
3 years, 9 months ago (2017-03-13 15:48:40 UTC) #3
Clemens Hammacher
3 years, 9 months ago (2017-03-13 15:48:52 UTC) #4
Michael Hablich
On 2017/03/13 15:48:52, Clemens Hammacher wrote: Thanks lgtm
3 years, 9 months ago (2017-03-13 16:19:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733923002/20001
3 years, 9 months ago (2017-03-13 16:19:31 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 16:22:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/9d3b8fce50058b9d5d30e14bf22a0cf8bae...

Powered by Google App Engine
This is Rietveld 408576698