Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2733883003: Makes ChildModalWindow not leak (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ChildModalWindow not leak WindowModalityController uses ChildModalWindow class. ChildModalWindow was leaking a Widget, causing problems in mash (WindowTreeClient CHECKs there are no windows left when destroyed). BUG=693114 TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2733883003 Cr-Commit-Position: refs/heads/master@{#455012} Committed: https://chromium.googlesource.com/chromium/src/+/fded3f5a07ab164d57fbb3ecd0e480009ff0cdca

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M ash/test/child_modal_window.h View 1 4 chunks +10 lines, -8 lines 0 comments Download
M ash/test/child_modal_window.cc View 1 5 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
3 years, 9 months ago (2017-03-07 00:32:35 UTC) #1
Elliot Glaysher
lgtm
3 years, 9 months ago (2017-03-07 00:50:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733883003/20001
3 years, 9 months ago (2017-03-07 00:56:18 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 01:10:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fded3f5a07ab164d57fbb3ecd0e4...

Powered by Google App Engine
This is Rietveld 408576698