Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2733843003: Fix a crash when receiving PAUSE action but no service is routed (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash when receiving PAUSE action but no service is routed In some situations the notification might fire PAUSE action although the session has no routed service. This is due to the intents fired by Android is asynchronous. This CL adds a null-check to solve the issue. BUG=698645 Review-Url: https://codereview.chromium.org/2733843003 Cr-Commit-Position: refs/heads/master@{#454945} Committed: https://chromium.googlesource.com/chromium/src/+/2fe2e35b5b0b1bd56218c7d8a452966c57593e90

Patch Set 1 #

Patch Set 2 : added unit tests #

Total comments: 1

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M content/browser/media/session/media_session_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/session/media_session_impl_service_routing_unittest.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Zhiqiang Zhang (Slow)
PTAL
3 years, 9 months ago (2017-03-06 19:16:23 UTC) #2
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/2733843003/diff/20001/content/browser/media/session/media_session_impl_service_routing_unittest.cc File content/browser/media/session/media_session_impl_service_routing_unittest.cc (right): https://codereview.chromium.org/2733843003/diff/20001/content/browser/media/session/media_session_impl_service_routing_unittest.cc#newcode413 content/browser/media/session/media_session_impl_service_routing_unittest.cc:413: ->DidReceiveAction(blink::mojom::MediaSessionAction::PAUSE); Add a comment that it should not ...
3 years, 9 months ago (2017-03-06 19:19:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733843003/40001
3 years, 9 months ago (2017-03-06 19:21:11 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:38:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2fe2e35b5b0b1bd56218c7d8a452...

Powered by Google App Engine
This is Rietveld 408576698