test262 roll

test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted
- Inserted a terrible hack to get around test262 tests with a $ in the name

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk

Review-Url: https://codereview.chromium.org/2733843002
Cr-Commit-Position: refs/heads/master@{#43749}
Committed: https://chromium.googlesource.com/v8/v8/+/01cc4f9fbbd901e51e03b09089d2371191196946

[Dan Ehrenberg, 2017-03-06 13:23:03]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 13:23:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 13:25:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 13:25:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Dan Ehrenberg, 2017-03-06 14:46:01]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 14:46:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 14:49:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 14:49:04]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Dan Ehrenberg, 2017-03-06 14:55:18]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 14:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-03-06 14:55:43]

Description was changed from

==========
test262 roll

R=adamk
==========

to

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- There is a test with $ in the name, so fix quoting for gyp
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

[commit-bot: I haz the power, 2017-03-06 14:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 14:58:54]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Dan Ehrenberg, 2017-03-10 23:16:34]

Description was changed from

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- There is a test with $ in the name, so fix quoting for gyp
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

to

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

[Dan Ehrenberg, 2017-03-10 23:16:43]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:16:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 23:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:19:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[Dan Ehrenberg, 2017-03-10 23:28:03]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-03-10 23:30:38]

littledan@chromium.org changed reviewers:
+ machenbach@google.com

[Dan Ehrenberg, 2017-03-10 23:30:39]

Hi Michael,

I'm having trouble with this test262 roll. There's an issue with the gyp
swarming setup due to a new test being introduced with a $ in its name. I
believe this ends up triggering an assertion in
https://chromium.googlesource.com/external/gyp/+/master/pylib/gyp/generator/n...
which expects that files will not contain $ in their paths, which you can see in
failed test runs here.

I wonder if there should be some method built to allow the $ to be escaped with
respect to gyp. However, it seems like doing this properly would require changes
to a bunch of other backends... I suppose all this code will be dead anyway when
we upgrade to gn swarming. Do you have any suggestions?

[Dan Ehrenberg, 2017-03-10 23:35:16]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-03-10 23:36:04]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 23:36:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2017-03-10 23:40:43]

lgtm for the tests, but deferring to machenbach on the gyp issue.

[commit-bot: I haz the power, 2017-03-10 23:52:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 23:52:59]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2017-03-13 08:24:08]

lgtm for the hack in patch 6. The (small) risk now is that if there's a test262
roll with a change to the $ file only, it wouldn't get re-archived. But I assume
that every test262 roll has many more changes and retriggers archiving.

I'd put the problem on the pile of our technical dept and make this higher prio
in Q2 planning.

[Dan Ehrenberg, 2017-03-13 14:13:47]

The CQ bit was checked by littledan@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:13:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Ehrenberg, 2017-03-13 14:29:40]

Description was changed from

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

to

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted
- Inserted a terrible hack to get around test262 tests with a $ in the name

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

[commit-bot: I haz the power, 2017-03-13 14:33:08]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489414427735020,
"parent_rev": "8e4be1a2e3bcf92a8064c3cee71542c37cca832e", "commit_rev":
"01cc4f9fbbd901e51e03b09089d2371191196946"}

[commit-bot: I haz the power, 2017-03-13 14:33:12]

Description was changed from

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted
- Inserted a terrible hack to get around test262 tests with a $ in the name

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk
==========

to

==========
test262 roll

A couple infrastructure changes went into this patch:
- test262 changed from expecting $ to $262
- upstream-local-tests.sh gets a command-line parameter for ease of use
- Fixed up the FAIL_SLOPPY infrastructure, which seems to have bit-rotted
- Inserted a terrible hack to get around test262 tests with a $ in the name

Drive-by fix for the length of Intl.DateTimeFormat.prototype.format

R=adamk

Review-Url: https://codereview.chromium.org/2733843002
Cr-Commit-Position: refs/heads/master@{#43749}
Committed:
https://chromium.googlesource.com/v8/v8/+/01cc4f9fbbd901e51e03b09089d23711911...
==========

[commit-bot: I haz the power, 2017-03-13 14:33:13]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/01cc4f9fbbd901e51e03b09089d23711911...