v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled.

src/base/macros.h

Index: src/base/macros.h
diff --git a/src/base/macros.h b/src/base/macros.h
index b99f01b230c52db6c11e90a49c608919ae6ccfab..5b3e90bc7d23699c1a0650f6ecfd94639b60dc50 100644
--- a/src/base/macros.h
+++ b/src/base/macros.h
@@ -54,15 +54,22 @@
 #define MUST_USE_RESULT V8_WARN_UNUSED_RESULT
 
 
-// Define DISABLE_ASAN macros.
+// Define ASAN_BUILD macros.
+#ifdef ASAN_BUILD
+#error "ASAN_BUILD macros must not be defined."
+#endif
+
 #if defined(__has_feature)
 #if __has_feature(address_sanitizer)
-#define DISABLE_ASAN __attribute__((no_sanitize_address))
+#define ASAN_BUILD 1

[Jakob Kummerow, 2014/05/12 16:57:01]

We already define V8_USE_ADDRESS_SANITIZER in zone.h based on the same logic.
You could move that here, and reuse it for TryCatch.
When the name begins with V8_, you can skip the "must not be defined already"
check above.

[Igor Sheludko, 2014/05/12 17:09:52]

Done.

 #endif
 #endif
 
 
-#ifndef DISABLE_ASAN
+// Define DISABLE_ASAN macros.
+#ifdef ASAN_BUILD
+#define DISABLE_ASAN __attribute__((no_sanitize_address))
+#else
 #define DISABLE_ASAN
 #endif