v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled.

src/base/macros.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BASE_MACROS_H_
 #define V8_BASE_MACROS_H_
 
 #include "../../include/v8stdint.h"
 
 
@@ skipping 36 matching lines @@
 
 // Newly written code should use V8_INLINE and V8_NOINLINE directly.
 #define INLINE(declarator)    V8_INLINE declarator
 #define NO_INLINE(declarator) V8_NOINLINE declarator
 
 
 // Newly written code should use V8_WARN_UNUSED_RESULT.
 #define MUST_USE_RESULT V8_WARN_UNUSED_RESULT
 
 
-// Define DISABLE_ASAN macros.
+// Define ASAN_BUILD macros.
+#ifdef ASAN_BUILD
+#error "ASAN_BUILD macros must not be defined."
+#endif
+
 #if defined(__has_feature)
 #if __has_feature(address_sanitizer)
-#define DISABLE_ASAN __attribute__((no_sanitize_address))
+#define ASAN_BUILD 1

[Jakob Kummerow, 2014/05/12 16:57:01]

We already define V8_USE_ADDRESS_SANITIZER in zone.h based on the same logic.
You could move that here, and reuse it for TryCatch.
When the name begins with V8_, you can skip the "must not be defined already"
check above.

[Igor Sheludko, 2014/05/12 17:09:52]

Done.

 #endif
 #endif
 
 
-#ifndef DISABLE_ASAN
+// Define DISABLE_ASAN macros.
+#ifdef ASAN_BUILD
+#define DISABLE_ASAN __attribute__((no_sanitize_address))
+#else
 #define DISABLE_ASAN
 #endif
 
 
 #if V8_CC_GNU
 #define V8_IMMEDIATE_CRASH() __builtin_trap()
 #else
 #define V8_IMMEDIATE_CRASH() ((void(*)())0)()
 #endif
 
 #endif   // V8_BASE_MACROS_H_