v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled.

v8::TryCatch now works correctly with ASAN's UseAfterReturn mode enabled.

BUG=chromium:369962
LOG=N
R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21273

[Igor Sheludko, 2014-05-12 15:49:56]

PTAL

[Jakob Kummerow, 2014-05-12 16:57:00]

Looks good, but I have a refactoring suggestion.

https://codereview.chromium.org/273383003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/273383003/diff/1/src/api.cc#newcode1912
src/api.cc:1912: asan_fake_stack_handle_ = 0;
nit: I'd prefer s/0/NULL/ for pointers.

https://codereview.chromium.org/273383003/diff/1/src/base/macros.h
File src/base/macros.h (right):

https://codereview.chromium.org/273383003/diff/1/src/base/macros.h#newcode64
src/base/macros.h:64: #define ASAN_BUILD 1
We already define V8_USE_ADDRESS_SANITIZER in zone.h based on the same logic.
You could move that here, and reuse it for TryCatch.
When the name begins with V8_, you can skip the "must not be defined already"
check above.

[Igor Sheludko, 2014-05-12 17:09:52]

https://codereview.chromium.org/273383003/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/273383003/diff/1/src/api.cc#newcode1912
src/api.cc:1912: asan_fake_stack_handle_ = 0;
On 2014/05/12 16:57:01, Jakob wrote:
> nit: I'd prefer s/0/NULL/ for pointers.

Done.

https://codereview.chromium.org/273383003/diff/1/src/base/macros.h
File src/base/macros.h (right):

https://codereview.chromium.org/273383003/diff/1/src/base/macros.h#newcode64
src/base/macros.h:64: #define ASAN_BUILD 1
On 2014/05/12 16:57:01, Jakob wrote:
> We already define V8_USE_ADDRESS_SANITIZER in zone.h based on the same logic.
> You could move that here, and reuse it for TryCatch.
> When the name begins with V8_, you can skip the "must not be defined already"
> check above.

Done.

[Jakob Kummerow, 2014-05-12 17:51:00]

lgtm

[Igor Sheludko, 2014-05-12 19:32:20]

Committed patchset #2 manually as r21273 (presubmit successful).