Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2733783003: TEXTAREA element: Updating child nodes without updating textContent should do nothing (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
yoichio
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TEXTAREA element: Updating child nodes without updating textContent should do nothing https://html.spec.whatwg.org/multipage/forms.html#the-textarea-element:textcontent > When the textarea element's textContent IDL attribute changes value, if the > element's dirty value flag is false, then the element's raw value must be set > to the value of the element's textContent IDL attribute. We should do nothing if textContent isn't changed. New behavior matches to Edge, Safari, and the standard, and doesn't match to Firefox. BUG=698647 Review-Url: https://codereview.chromium.org/2733783003 Cr-Commit-Position: refs/heads/master@{#454840} Committed: https://chromium.googlesource.com/chromium/src/+/5cd3e773b0851d6e56bc2bcb46802c637c50b837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-selection-preservation.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-selection-preservation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 2 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yoichio@, would you review this please?
3 years, 9 months ago (2017-03-06 08:31:42 UTC) #4
yoichio
lgtm
3 years, 9 months ago (2017-03-06 08:48:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733783003/1
3 years, 9 months ago (2017-03-06 09:22:53 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 09:27:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5cd3e773b0851d6e56bc2bcb4680...

Powered by Google App Engine
This is Rietveld 408576698