cc/layers/layer_sticky_position_constraint.cc - Issue 2733633002: Handle nested position:sticky elements correctly (compositor)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_sticky_position_constraint.cc

Issue 2733633002: Handle nested position:sticky elements correctly (compositor) (Closed)

Patch Set: Addressed the easier reviewer comments. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer_sticky_position_constraint.cc

diff --git a/cc/layers/layer_sticky_position_constraint.cc b/cc/layers/layer_sticky_position_constraint.cc

index 79414d6a8775daeb4d3a0a67a9b4717cdb61432e..bb7478734cee8db4abbb1ab0540e27be515fbd0b 100644

--- a/cc/layers/layer_sticky_position_constraint.cc

+++ b/cc/layers/layer_sticky_position_constraint.cc

@@ -15,7 +15,9 @@ LayerStickyPositionConstraint::LayerStickyPositionConstraint()

left_offset(0.f),

right_offset(0.f),

top_offset(0.f),

- bottom_offset(0.f) {}

+ bottom_offset(0.f),

+ nearest_layer_shifting_sticky_box(nullptr),

+ nearest_layer_shifting_containing_block(nullptr) {}

LayerStickyPositionConstraint::LayerStickyPositionConstraint(

const LayerStickyPositionConstraint& other)

@@ -33,7 +35,15 @@ LayerStickyPositionConstraint::LayerStickyPositionConstraint(

scroll_container_relative_sticky_box_rect(

other.scroll_container_relative_sticky_box_rect),

scroll_container_relative_containing_block_rect(

- other.scroll_container_relative_containing_block_rect) {}

+ other.scroll_container_relative_containing_block_rect),

+ nearest_layer_shifting_sticky_box(

+ other.nearest_layer_shifting_sticky_box),

+ nearest_layer_shifting_containing_block(

+ other.nearest_layer_shifting_containing_block),

+ total_sticky_box_sticky_offset(other.total_sticky_box_sticky_offset),

+ total_containing_block_sticky_offset(

+ other.total_containing_block_sticky_offset),

+ local_sticky_offset(other.local_sticky_offset) {}

bool LayerStickyPositionConstraint::operator==(

const LayerStickyPositionConstraint& other) const {

@@ -52,7 +62,16 @@ bool LayerStickyPositionConstraint::operator==(

scroll_container_relative_sticky_box_rect ==

other.scroll_container_relative_sticky_box_rect &&

scroll_container_relative_containing_block_rect ==

- other.scroll_container_relative_containing_block_rect;

+ other.scroll_container_relative_containing_block_rect &&

+ nearest_layer_shifting_sticky_box ==

+ other.nearest_layer_shifting_sticky_box &&

+ nearest_layer_shifting_containing_block ==

+ other.nearest_layer_shifting_containing_block &&

+ total_sticky_box_sticky_offset ==

+ other.total_sticky_box_sticky_offset &&

+ total_containing_block_sticky_offset ==

+ other.total_containing_block_sticky_offset &&

+ local_sticky_offset == other.local_sticky_offset;

}

bool LayerStickyPositionConstraint::operator!=(

« no previous file with comments | « cc/layers/layer_sticky_position_constraint.h ('k') | cc/trees/draw_property_utils.h » ('j') | cc/trees/property_tree.cc » ('J')