Chromium Code Reviews Chromium Code Reviews
Issue
2733433002:
[Win10 FRE] Make inlined-image more Polymer-friendly to fix <action-link> CSS inclusion. (Closed)
Description[Win10 FRE] Make inlined-image more Polymer-friendly to fix <action-link> CSS inclusion.
Win10 FRE's did not integrate with Polymer properly, and as a result,
<action-link>'s CSS was ignored. This caused .no-outline to be
ineffective, so blue border appears when such a link gets clicked.
This CL picks up tmartino@'s draft Polymer integration code, and fix
the bug. Details:
- Create <dom-module id="welcome-win10-inline">, which absorbs most of
the contents of inline.css (except <body> styles).
- Instantiate content <welcome-win10-inline>.
- inline.js: Add Polymer({is: 'welcome-win10-inline', ...}), and adapt
existing initialization code plus handlers.
- Key to include action-link CSS: <dom-module> requires
<style include="action-link">...</style>
- Fix centering: <dom-module> (see :host) has "display: inline-flex"
along colun direction with "align-item: flex-start". The <body> of
the main page becomes "display: flex" for centering.
BUG=697140
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2733433002
Cr-Commit-Position: refs/heads/master@{#454524}
Committed: https://chromium.googlesource.com/chromium/src/+/7b228893a73bb4c1c971657adb9cd029a0d4b0ef
Patch Set 1 #Patch Set 2 : Fix indentations for CSS and comments. #
Total comments: 5
Patch Set 3 : Remove .content; reorder Polymer 'properties' field. #
Messages
Total messages: 21 (9 generated)
|
|||||||||||||||||||||||||||||||||||||
