Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 2732293004: Install default constructors on broken mixin applications. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Install default constructors on broken mixin applications. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/3ed36f5c4639769ec5c6c0a59f0d4a6249d65e64

Patch Set 1 #

Patch Set 2 : Update test/fasta/rasta/class_hierarchy.dart.outline.expect #

Patch Set 3 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 2 chunks +15 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/class_hierarchy.dart.outline.expect View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-08 15:03:27 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-09 09:46:49 UTC) #3
ahe
3 years, 9 months ago (2017-03-09 12:12:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
3ed36f5c4639769ec5c6c0a59f0d4a6249d65e64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698