Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2733393002: [typedarrays] check byte offset for fast typedarray sort (Closed)

Created:
3 years, 9 months ago by Choongwoo Han
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[typedarrays] check byte offset for fast typedarray sort BUG=v8:5953 Review-Url: https://codereview.chromium.org/2733393002 Cr-Commit-Position: refs/heads/master@{#43666} Committed: https://chromium.googlesource.com/v8/v8/+/5fc1bd5b32be6812c8e09d2486a81eb7d0918a1c

Patch Set 1 #

Patch Set 2 : Use DataPtr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/runtime/runtime-typedarray.cc View 1 1 chunk +11 lines, -10 lines 0 comments Download
M test/mjsunit/es6/typedarray-sort.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Choongwoo Han
PTAL. I found a bug from the patch I submitted before. Sorry for too many ...
3 years, 9 months ago (2017-03-08 08:11:02 UTC) #3
Benedikt Meurer
lgtm
3 years, 9 months ago (2017-03-08 09:20:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733393002/20001
3 years, 9 months ago (2017-03-08 11:08:20 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 12:01:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5fc1bd5b32be6812c8e09d2486a81eb7d09...

Powered by Google App Engine
This is Rietveld 408576698