Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2733353003:
Android: Upstream gn_to_cmake.py (Closed)
|
Created:
3 years, 9 months ago by Peter Wen Modified:
3 years, 9 months ago CC:
chromium-reviews, mikecase+watch_chromium.org, nyquist+watch_chromium.org, jbudorick+watch_chromium.org, wnwen+watch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAndroid: Upstream gn_to_cmake.py
The script was originally //third_party/skia/gn/gn_to_cmake.py
Planning to use it to enable editing native files in android studio.
Currently script does not allow full build, intended for editing only.
BUG=694699
Review-Url: https://codereview.chromium.org/2733353003
Cr-Commit-Position: refs/heads/master@{#455521}
Committed: https://chromium.googlesource.com/chromium/src/+/a45e8b336d2b214cfd5db0b3e3b5b85b688ce8db
Patch Set 1 #Patch Set 2 : Fix style issues. #Messages
Total messages: 18 (8 generated)
wnwen@chromium.org changed reviewers: + bungeman@chromium.org
Hi Ben, I'm looking to upstream your script and make some changes for android studio. PTAL. Thanks, Peter
If you have no issues with it, I have no issues with it, so lgtm. Might want to make it more explicit that this is (at least currently) designed around editing and any builds may or may not be as expected.
Description was changed from ========== Android: Upstream gn_to_cmake.py The script was originally //third_party/skia/gn/gn_to_cmake.py BUG=694699 ========== to ========== Android: Upstream gn_to_cmake.py The script was originally //third_party/skia/gn/gn_to_cmake.py Planning to use it to enable editing native files in android studio. Currently script does not allow full build, intended for editing only. BUG=694699 ==========
wnwen@chromium.org changed reviewers: + agrieve@chromium.org
Done. Thanks for the review! +agrieve@ for OWNERS.
On 2017/03/08 17:29:07, Peter Wen wrote: > Done. Thanks for the review! > > +agrieve@ for OWNERS. lgtm
On 2017/03/08 17:51:37, agrieve wrote: > On 2017/03/08 17:29:07, Peter Wen wrote: > > Done. Thanks for the review! > > > > +agrieve@ for OWNERS. > > lgtm Also - feel free to add yourself to gradle/OWNERS
Thanks Andrew, will add OWNERS in a separate CL.
The CQ bit was checked by wnwen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by wnwen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489000892959400,
"parent_rev": "cc17746adff54984afff480136733114c6b3704b", "commit_rev":
"a45e8b336d2b214cfd5db0b3e3b5b85b688ce8db"}
Message was sent while issue was closed.
Description was changed from ========== Android: Upstream gn_to_cmake.py The script was originally //third_party/skia/gn/gn_to_cmake.py Planning to use it to enable editing native files in android studio. Currently script does not allow full build, intended for editing only. BUG=694699 ========== to ========== Android: Upstream gn_to_cmake.py The script was originally //third_party/skia/gn/gn_to_cmake.py Planning to use it to enable editing native files in android studio. Currently script does not allow full build, intended for editing only. BUG=694699 Review-Url: https://codereview.chromium.org/2733353003 Cr-Commit-Position: refs/heads/master@{#455521} Committed: https://chromium.googlesource.com/chromium/src/+/a45e8b336d2b214cfd5db0b3e3b5... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a45e8b336d2b214cfd5db0b3e3b5... |
