PPC/s390: [assembler] Make register definitions constexpr

PPC/s390: [assembler] Make register definitions constexpr

Port e82b7ccd3211e226649c73148574c1967ba647e4

Original Commit Message:

    I originally needed this for the initialization of a constexpr array in
    the wasm lazy compile builtin, but since it's a bigger change, I now
    split it off as this separate CL.
    The style guide recommends constexpr over const. I thus apply the
    constexprificaton over all headers that I touched anyway.

    I also remove the ARM64_DEFINE_REG_STATICS hack. It was introduced when
    merging in arm64 support more than three years ago, and I don't see the
    purpose for this.
    Also, some #defines can now be constexpr definitions, which was not
    possible before according to the comment.

R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2733323003
Cr-Commit-Position: refs/heads/master@{#43678}
Committed: https://chromium.googlesource.com/v8/v8/+/e7be85daf69bbf9adef4841eae2839e4075f40f7

[JaideepBajwa, 2017-03-08 06:13:28]

ptal

[JoranSiu, 2017-03-08 06:40:38]

On 2017/03/08 06:13:28, JaideepBajwa wrote:
> ptal

lgtm

[Clemens Hammacher, 2017-03-08 09:13:47]

LGTM with nits

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h
File src/ppc/assembler-ppc.h (right):

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:197: #define DECLARE_REGISTER(R) constexpr Register R =
{Register::kCode_##R};
You might want to rename this to DEFINE_REGISTER, since that's what this macro
does.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:248: #define DECLARE_REGISTER(R) \
same here.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:255: // "static const DoubleRegister&" because Clang
complains otherwise when a
This comment is obsolete.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:296: const RelocInfo::Mode kRelocInfo_NONEPTR =
RelocInfo::NONE64;
This can also be constexpr.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h
File src/s390/assembler-s390.h (right):

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:179: #define DECLARE_REGISTER(R) constexpr Register R
= {Register::kCode_##R};
DEFINE_REGISTER

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:231: #define DECLARE_REGISTER(R) \
DEFINE_REGISTER

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:238: // "static const DoubleRegister&" because Clang
complains otherwise when a
Obsolete comment.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:277: const RelocInfo::Mode kRelocInfo_NONEPTR =
RelocInfo::NONE64;
constexpr

[john.yan, 2017-03-08 15:10:10]

lgtm

[JaideepBajwa, 2017-03-08 15:59:49]

thank you.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h
File src/ppc/assembler-ppc.h (right):

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:197: #define DECLARE_REGISTER(R) constexpr Register R =
{Register::kCode_##R};
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> You might want to rename this to DEFINE_REGISTER, since that's what this macro
> does.

Done.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:248: #define DECLARE_REGISTER(R) \
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> same here.

Done.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:255: // "static const DoubleRegister&" because Clang
complains otherwise when a
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> This comment is obsolete.

Done.

https://codereview.chromium.org/2733323003/diff/1/src/ppc/assembler-ppc.h#new...
src/ppc/assembler-ppc.h:296: const RelocInfo::Mode kRelocInfo_NONEPTR =
RelocInfo::NONE64;
On 2017/03/08 09:13:46, Clemens Hammacher wrote:
> This can also be constexpr.

Done.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h
File src/s390/assembler-s390.h (right):

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:179: #define DECLARE_REGISTER(R) constexpr Register R
= {Register::kCode_##R};
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> DEFINE_REGISTER

Done.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:231: #define DECLARE_REGISTER(R) \
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> DEFINE_REGISTER

Done.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:238: // "static const DoubleRegister&" because Clang
complains otherwise when a
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> Obsolete comment.

Done.

https://codereview.chromium.org/2733323003/diff/1/src/s390/assembler-s390.h#n...
src/s390/assembler-s390.h:277: const RelocInfo::Mode kRelocInfo_NONEPTR =
RelocInfo::NONE64;
On 2017/03/08 09:13:47, Clemens Hammacher wrote:
> constexpr

Done.

[JaideepBajwa, 2017-03-08 16:00:03]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2017-03-08 16:00:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org, jyan@ca.ibm.com, joransiu@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2733323003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-08 16:00:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 16:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488988803524970,
"parent_rev": "cb3f1376396e45dae15032913fb4afb4141566ca", "commit_rev":
"e7be85daf69bbf9adef4841eae2839e4075f40f7"}

[commit-bot: I haz the power, 2017-03-08 16:24:07]

Description was changed from

==========
PPC/s390: [assembler] Make register definitions constexpr

Port e82b7ccd3211e226649c73148574c1967ba647e4

Original Commit Message:

    I originally needed this for the initialization of a constexpr array in
    the wasm lazy compile builtin, but since it's a bigger change, I now
    split it off as this separate CL.
    The style guide recommends constexpr over const. I thus apply the
    constexprificaton over all headers that I touched anyway.

    I also remove the ARM64_DEFINE_REG_STATICS hack. It was introduced when
    merging in arm64 support more than three years ago, and I don't see the
    purpose for this.
    Also, some #defines can now be constexpr definitions, which was not
    possible before according to the comment.

R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=
LOG=N
==========

to

==========
PPC/s390: [assembler] Make register definitions constexpr

Port e82b7ccd3211e226649c73148574c1967ba647e4

Original Commit Message:

    I originally needed this for the initialization of a constexpr array in
    the wasm lazy compile builtin, but since it's a bigger change, I now
    split it off as this separate CL.
    The style guide recommends constexpr over const. I thus apply the
    constexprificaton over all headers that I touched anyway.

    I also remove the ARM64_DEFINE_REG_STATICS hack. It was introduced when
    merging in arm64 support more than three years ago, and I don't see the
    purpose for this.
    Also, some #defines can now be constexpr definitions, which was not
    possible before according to the comment.

R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com
BUG=
LOG=N

Review-Url: https://codereview.chromium.org/2733323003
Cr-Commit-Position: refs/heads/master@{#43678}
Committed:
https://chromium.googlesource.com/v8/v8/+/e7be85daf69bbf9adef4841eae2839e4075...
==========

[commit-bot: I haz the power, 2017-03-08 16:24:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e7be85daf69bbf9adef4841eae2839e4075...