components/crash/content/app/fallback_crash_handler_win_unittest.cc - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/fallback_crash_handler_win_unittest.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fix Windows build. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/process_unittest.cc ('K') | « components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc ('k') | components/crash/content/app/fallback_crash_handling_win_unittest.cc » ('j') | content/browser/memory/memory_coordinator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/fallback_crash_handler_win_unittest.cc

diff --git a/components/crash/content/app/fallback_crash_handler_win_unittest.cc b/components/crash/content/app/fallback_crash_handler_win_unittest.cc

index 13ca131f0204c80ae3b82f4d5e95d0649be88b0d..92c008ea80465b23675238ca0af3c593a3d9e056 100644

--- a/components/crash/content/app/fallback_crash_handler_win_unittest.cc

+++ b/components/crash/content/app/fallback_crash_handler_win_unittest.cc

@@ -169,12 +169,12 @@ TEST_F(FallbackCrashHandlerWinTest, GenerateCrashDump) {

cmd_line.AppendSwitchPath("directory", database_dir_.GetPath());

base::LaunchOptions options;

options.start_hidden = true;

- base::Process test_child = base::SpawnMultiProcessTestChild(

+ base::SpawnChildResult spawn_child = base::SpawnMultiProcessTestChild(

"FallbackCrashHandlerWinMain", cmd_line, options);

- ASSERT_TRUE(test_child.IsValid());

+ ASSERT_TRUE(spawn_child.process.IsValid());

int exit_code = -1;

- ASSERT_TRUE(test_child.WaitForExit(&exit_code));

+ ASSERT_TRUE(spawn_child.process.WaitForExit(&exit_code));

ASSERT_EQ(0, exit_code);

// Validate that the database contains one valid crash dump.