components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fix Windows build. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/process/process_unittest.cc ('K') | « components/browser_watcher/exit_code_watcher_win_unittest.cc ('k') | components/crash/content/app/fallback_crash_handler_win_unittest.cc » ('j') | content/browser/memory/memory_coordinator_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc

diff --git a/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc b/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc

index c19ae79d17dca9ad4631a3b1fc5a6bca1a2350a8..07340432cece71376b7cc7b8a779de17f8191483 100644

--- a/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc

+++ b/components/crash/content/app/fallback_crash_handler_launcher_win_unittest.cc

@@ -143,9 +143,10 @@ TEST_F(FallbackCrashHandlerLauncherTest, LaunchAndWaitForHandler) {

// Because this process is heavily multithreaded it's going to be flaky

// and generally fraught with peril to try and grab a minidump of it.

// Instead, fire off a sacrificial process to do the testing.

- base::Process test_process = SpawnChild("TestCrashHandlerLauncherMain");

+ base::SpawnChildResult spawn_child =

+ SpawnChild("TestCrashHandlerLauncherMain");

int exit_code = 0;

- ASSERT_TRUE(test_process.WaitForExit(&exit_code));

+ ASSERT_TRUE(spawn_child.process.WaitForExit(&exit_code));

ASSERT_EQ(0, exit_code);

}