Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: sandbox/mac/sandbox_mac_compiler_unittest.mm

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)
Patch Set: Fixed bots. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sandbox/mac/sandbox_mac_compiler_unittest.mm
diff --git a/sandbox/mac/sandbox_mac_compiler_unittest.mm b/sandbox/mac/sandbox_mac_compiler_unittest.mm
index 404bf4bbabb9e8d2bcb0ed491c95c8063de98a64..598b0ba3198652bd7ae405e5fc86ba3435b704fa 100644
--- a/sandbox/mac/sandbox_mac_compiler_unittest.mm
+++ b/sandbox/mac/sandbox_mac_compiler_unittest.mm
@@ -32,7 +32,8 @@ MULTIPROCESS_TEST_MAIN(BasicProfileProcess) {
}
TEST_F(SandboxMacCompilerTest, BasicProfileTest) {
- base::Process process = SpawnChild("BasicProfileProcess");
+ base::SpawnChildResult spawn_result = SpawnChild("BasicProfileProcess");
+ base::Process process = std::move(spawn_result.process);
ASSERT_TRUE(process.IsValid());
int exit_code = 42;
EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
@@ -55,7 +56,9 @@ MULTIPROCESS_TEST_MAIN(BasicProfileWithParamProcess) {
}
TEST_F(SandboxMacCompilerTest, BasicProfileTestWithParam) {
- base::Process process = SpawnChild("BasicProfileWithParamProcess");
+ base::SpawnChildResult spawn_result =
+ SpawnChild("BasicProfileWithParamProcess");
+ base::Process process = std::move(spawn_result.process);
ASSERT_TRUE(process.IsValid());
int exit_code = 42;
EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
@@ -86,7 +89,8 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTest) {
- base::Process process = SpawnChild("ProfileFunctionalProcess");
+ base::SpawnChildResult spawn_result = SpawnChild("ProfileFunctionalProcess");
+ base::Process process = std::move(spawn_result.process);
ASSERT_TRUE(process.IsValid());
int exit_code = 42;
EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
@@ -126,7 +130,9 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalTestWithParamsProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestWithParams) {
- base::Process process = SpawnChild("ProfileFunctionalTestWithParamsProcess");
+ base::SpawnChildResult spawn_result =
+ SpawnChild("ProfileFunctionalTestWithParamsProcess");
+ base::Process process = std::move(spawn_result.process);
ASSERT_TRUE(process.IsValid());
int exit_code = 42;
EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),
@@ -149,7 +155,9 @@ MULTIPROCESS_TEST_MAIN(ProfileFunctionalityTestErrorProcess) {
}
TEST_F(SandboxMacCompilerTest, ProfileFunctionalityTestError) {
- base::Process process = SpawnChild("ProfileFunctionalityTestErrorProcess");
+ base::SpawnChildResult spawn_result =
+ SpawnChild("ProfileFunctionalityTestErrorProcess");
+ base::Process process = std::move(spawn_result.process);
ASSERT_TRUE(process.IsValid());
int exit_code = 42;
EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),

Powered by Google App Engine
This is Rietveld 408576698