sandbox/mac/sandbox_mac_compiler_v2_unittest.mm - Issue 2733323002: Changing multiprocess test SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

Issue 2733323002: Changing multiprocess test SpawnChild to return a struct. (Closed)

Patch Set: Fixed bots. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

diff --git a/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm b/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

index aba42edbc9478a7fe05f7a73c533ed5330ca8a33..57fdd3ed322f395ef0cd4c378de430f0597842a8 100644

--- a/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

+++ b/sandbox/mac/sandbox_mac_compiler_v2_unittest.mm

@@ -126,7 +126,8 @@ MULTIPROCESS_TEST_MAIN(V2ProfileProcess) {

}

TEST_F(SandboxMacCompilerV2Test, V2ProfileTest) {

- base::Process process = SpawnChild("V2ProfileProcess");

+ base::SpawnChildResult spawn_result = SpawnChild("V2ProfileProcess");

+ base::Process process = std::move(spawn_result.process);

ASSERT_TRUE(process.IsValid());

int exit_code = 42;

EXPECT_TRUE(process.WaitForExitWithTimeout(TestTimeouts::action_max_timeout(),