Expose WebServiceWorkerNetworkProvider on DataSource

third_party/WebKit/Source/core/loader/DocumentLoader.h

Index: third_party/WebKit/Source/core/loader/DocumentLoader.h
diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.h b/third_party/WebKit/Source/core/loader/DocumentLoader.h
index caa44f8693dd6a932d4be75e4686330e720a8d73..33187cb35b36869f34596062cf8737b3fddd7202 100644
--- a/third_party/WebKit/Source/core/loader/DocumentLoader.h
+++ b/third_party/WebKit/Source/core/loader/DocumentLoader.h
@@ -64,6 +64,7 @@ class LocalFrame;
 class LocalFrameClient;
 class FrameLoader;
 class ResourceTimingInfo;
+class WebServiceWorkerNetworkProvider;
 struct ViewportDescriptionWrapper;
 
 class CORE_EXPORT DocumentLoader
@@ -189,6 +190,12 @@ class CORE_EXPORT DocumentLoader
 
   Resource* startPreload(Resource::Type, FetchRequest&);
 
+  void setServiceWorkerNetworkProvider(
+      std::unique_ptr<WebServiceWorkerNetworkProvider>);
+  WebServiceWorkerNetworkProvider* getServiceWorkerNetworkProvider() {

[falken, 2017/03/10 04:26:00]

It seems worth documenting that this can be null. (Do you know in which cases it
can be null? I guess it's before the document has finished loading?)

also (nit) Should this just be serviceWorkerNetworkProvider()? This class isn't
consistent about it though.

[kinuko, 2017/03/10 05:52:29]

Done.  Also removed some null checks that seem unnecessary.
 
I generally add get/set prefix for new code, once great rename happens it'd
become more natural.

+    return m_serviceWorkerNetworkProvider.get();
+  }
+
   DECLARE_VIRTUAL_TRACE();
 
  protected:
@@ -283,6 +290,9 @@ class CORE_EXPORT DocumentLoader
 
   Member<ApplicationCacheHost> m_applicationCacheHost;
 
+  std::unique_ptr<WebServiceWorkerNetworkProvider>
+      m_serviceWorkerNetworkProvider;

[kinuko, 2017/03/09 16:23:03]

This change exposes ServiceWorker to DocumentLoader, but we already leak SW
concept at many places in core/ and I think it's better to centralize SW-related
plumbing into this one

+
   Member<ContentSecurityPolicy> m_contentSecurityPolicy;
   ClientHintsPreferences m_clientHintsPreferences;
   InitialScrollState m_initialScrollState;