extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc - Issue 2733283002: Require explicit selection of traits for LazyInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 2733283002: Require explicit selection of traits for LazyInstance (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/browser_context_keyed_api_factory.h ('K') | « extensions/renderer/extension_frame_helper.cc ('k') | extensions/renderer/renderer_extension_registry.cc » ('j') | ui/events/keycodes/platform_key_map_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

index 77bc51f90115172134dee545dd4d04e3e0f5b7bd..d9a09ffe3d2a9fd0f14e18790959a27663ea67d0 100644

--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

@@ -39,7 +39,8 @@ namespace {

// GuestViewInternalCustomBindings::RegisterView(), and accessed via

// GuestViewInternalCustomBindings::GetViewFromID().

using ViewMap = std::map<int, v8::Global<v8::Object>*>;

-static base::LazyInstance<ViewMap> weak_view_map = LAZY_INSTANCE_INITIALIZER;

+static base::LazyInstance<ViewMap>::DestructorAtExit weak_view_map =

+ LAZY_INSTANCE_INITIALIZER;

} // namespace